From: lorentey@elte.hu (Károly Lőrentey)
Cc: Karoly Lorentey <karoly@lorentey.hu>, emacs-devel@gnu.org
Subject: Re: Wrong fix?
Date: Sun, 12 Mar 2006 23:52:02 +0100 [thread overview]
Message-ID: <lorentey.m.other.87lkvfl1il.elte@walrus.fnord.hu> (raw)
In-Reply-To: <E1FISlK-0000MC-4i@fencepost.gnu.org> (Richard Stallman's message of "Sun, 12 Mar 2006 10:45:42 -0500")
[-- Attachment #1.1: Type: text/plain, Size: 1096 bytes --]
Richard Stallman <rms@gnu.org> writes:
> +#if 0 /* x_get_arg removes the visibility parameter as a side effect,
> + but x_create_frame still needs it. */
> /* Start up iconic or window? */
> x_wm_set_window_state
> (f, (EQ (x_get_arg (dpyinfo, parms, Qvisibility, 0, 0, RES_TYPE_SYMBOL),
> Qicon)
> ? IconicState
> : NormalState));
> +#endif
>
> That seems like the wrong fix to me. If the goal is simply
> to prevent x_get_arg from clearing out the parameter,
> then this goes too far--it also prevents the parameter from being used
> for calling x_wm_set_window_state.
I chose the easier path of disabling the call because `x_create_frame'
sets the WM hints later anyway, by calling `x_iconify_frame' or
`x_make_frame_visible'. I did not find any reason to call
`x_wm_set_window_state' twice, but if people know of such a reason, I
will implement a better fix.
(The patch was committed to get rid of the annoying flicker
while creating an invisible frame:)
(make-frame '((visibility . nil)))
--
Károly
[-- Attachment #1.2: Type: application/pgp-signature, Size: 190 bytes --]
[-- Attachment #2: Type: text/plain, Size: 142 bytes --]
_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel
next prev parent reply other threads:[~2006-03-12 22:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-12 15:45 Wrong fix? Richard Stallman
2006-03-12 22:52 ` Károly Lőrentey [this message]
2006-03-13 12:55 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=lorentey.m.other.87lkvfl1il.elte@walrus.fnord.hu \
--to=lorentey@elte.hu \
--cc=emacs-devel@gnu.org \
--cc=karoly@lorentey.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).