From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: lorentey@elte.hu (=?utf-8?Q?L=C5=91rentey_K=C3=A1roly?=) Newsgroups: gmane.emacs.devel Subject: Re: Buffer listing in multiple frames/ttys Date: Tue, 29 Nov 2005 11:45:09 +0100 Message-ID: References: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: sea.gmane.org 1133270175 12262 80.91.229.2 (29 Nov 2005 13:16:15 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 29 Nov 2005 13:16:15 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Nov 29 14:16:10 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1Eh4WZ-0003O2-TN for ged-emacs-devel@m.gmane.org; Tue, 29 Nov 2005 13:23:57 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Eh4WY-00044l-Dw for ged-emacs-devel@m.gmane.org; Tue, 29 Nov 2005 07:23:54 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Eh3d4-0003w5-8V for emacs-devel@gnu.org; Tue, 29 Nov 2005 06:26:35 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Eh3Zh-0003My-VH for emacs-devel@gnu.org; Tue, 29 Nov 2005 06:24:39 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Eh2yc-0001Hs-BM for emacs-devel@gnu.org; Tue, 29 Nov 2005 05:44:48 -0500 Original-Received: from [212.92.23.158] (helo=ninsei.hu) by monty-python.gnu.org with esmtp (Exim 4.34) id 1Eh2yc-0004T2-11 for emacs-devel@gnu.org; Tue, 29 Nov 2005 05:44:46 -0500 Original-Received: from walrus (walrus.inf.elte.hu [157.181.166.149]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by chatsubo.ninsei.hu (Postfix) with ESMTP id DA84A1ACA1 for ; Tue, 29 Nov 2005 11:44:43 +0100 (CET) Original-Received: by walrus (Postfix, from userid 1000) id 08B8E5E136; Tue, 29 Nov 2005 11:45:10 +0100 (CET) Original-To: emacs-devel@gnu.org In-Reply-To: (Drew Adams's message of "Mon, 28 Nov 2005 15:12:47 -0800") User-Agent: Gnus/5.110004 (No Gnus v0.4) Emacs/22.0.52 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:46759 Archived-At: --=-=-= Drew Adams writes: > The default ordering is chronological, so, yes, the most recent > buffer is always first. The relative order of the other buffers is > not changed, however (currently). > > Your reordering goes beyond that - the change in order is confusing, > unless one is thinking in terms of multiple buffers per frame and > one knows about the new behavior. Well, if there is any change in the relative order, then that implies that the frames sometimes change what buffer they display. The `buffer-list' frame parameter contains a chronological list of buffers that were ever displayed in the frame. The new code will not change the relative order of buffers in *Buffer List* unless this list has more than one entry. But that would imply that the user does use multiple buffers per frame, so arguably the new code can be useful. How about that! :-) I think we have spent too much time on this. I agree that there is no point in having frame-local buffer lists when pop-up-frames is set to t, so I propose in that case we continue to use the global buffer-list, as before. However, the frame-local version does have important benefits for the "thematic frame" people and when there are multiple terminals, so let's keep it enabled when pop-up-frames is not set. > That means that the new behavior would need to be documented > explicitly, or else people will not understand what they see. I will do that, of course. > Given that, I can't say I'm annoyed by your change. I was thinking > of the (imagined) need to re-sort. So, should I apply this patch or not? :-) --=-=-= Content-Type: text/x-patch Content-Disposition: attachment Index: buff-menu.el =================================================================== RCS file: /cvsroot/emacs/emacs/lisp/buff-menu.el,v retrieving revision 1.95 diff -u -3 -p -r1.95 buff-menu.el *** buff-menu.el 28 Nov 2005 14:36:06 -0000 1.95 --- buff-menu.el 29 Nov 2005 09:48:51 -0000 *************** *** 722,728 **** (if (memq c '(?\n ?\s)) c underline)) header))))) ;; Collect info for every buffer we're interested in. ! (dolist (buffer (or buffer-list (buffer-list (selected-frame)))) (with-current-buffer buffer (let ((name (buffer-name)) (file buffer-file-name)) --- 722,731 ---- (if (memq c '(?\n ?\s)) c underline)) header))))) ;; Collect info for every buffer we're interested in. ! (dolist (buffer (or buffer-list ! ;; Use the frame-local list when it makes sense. ! (buffer-list (and (not pop-up-frames) ! (selected-frame))))) (with-current-buffer buffer (let ((name (buffer-name)) (file buffer-file-name)) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable > [However, I have my own extension to the column-sorting that adds a > Time column, which shows the `buffer-display-time'. If I sort on > that column, will I need to re-sort? I don't know - is > `buffer-display-time' what is used in your ordering? That's what my > "Time" column uses.] No, Emacs simply uses the above mentioned frame parameter together with the global list to generate the frame-local ordering---it doesn't mess with the recorded display time for this. Therefore, I think that using the frame-local buffer-list should not affect your sorting results. --=20 K=C3=A1roly --=-=-= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Emacs-devel mailing list Emacs-devel@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-devel --=-=-=--