* Recent commits break compilation for MinGW64
@ 2016-02-11 7:20 Fabrice Popineau
2016-02-11 20:40 ` Eli Zaretskii
0 siblings, 1 reply; 3+ messages in thread
From: Fabrice Popineau @ 2016-02-11 7:20 UTC (permalink / raw)
To: emacs-devel
Hi,
The commits
456c0a3137bf58ee61a8e442cff0ca5d808e8d32
and
25ec995c064d4e658fe3f9af084f120ae21a021a
on lib-src/make-docfile.c
break compilation for MinGW64.
The use of va_start() and consorts
requires
#include <stdarg.h>
at least for WINDOWSNT.
Best regards,
Fabrice
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Recent commits break compilation for MinGW64
2016-02-11 7:20 Recent commits break compilation for MinGW64 Fabrice Popineau
@ 2016-02-11 20:40 ` Eli Zaretskii
2016-02-11 21:33 ` Paul Eggert
0 siblings, 1 reply; 3+ messages in thread
From: Eli Zaretskii @ 2016-02-11 20:40 UTC (permalink / raw)
To: Fabrice Popineau; +Cc: emacs-devel
> From: Fabrice Popineau <fabrice.popineau@gmail.com>
> Date: Thu, 11 Feb 2016 07:20:32 +0000 (UTC)
>
> The commits
> 456c0a3137bf58ee61a8e442cff0ca5d808e8d32
> and
> 25ec995c064d4e658fe3f9af084f120ae21a021a
> on lib-src/make-docfile.c
> break compilation for MinGW64.
> The use of va_start() and consorts
> requires
> #include <stdarg.h>
> at least for WINDOWSNT.
I think such commits shouldn't happen at all on emacs-25, but on
master. IMO, the time for cleanups on the release branch has come and
gone.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Recent commits break compilation for MinGW64
2016-02-11 20:40 ` Eli Zaretskii
@ 2016-02-11 21:33 ` Paul Eggert
0 siblings, 0 replies; 3+ messages in thread
From: Paul Eggert @ 2016-02-11 21:33 UTC (permalink / raw)
To: Eli Zaretskii, Fabrice Popineau; +Cc: emacs-devel
[-- Attachment #1: Type: text/plain, Size: 840 bytes --]
On 02/11/2016 12:40 PM, Eli Zaretskii wrote:
>> From: Fabrice Popineau <fabrice.popineau@gmail.com>
>> Date: Thu, 11 Feb 2016 07:20:32 +0000 (UTC)
>>
>> The use of va_start() and consorts
>> requires
>> #include <stdarg.h>
Sorry about that. Fixed with the attached. On GNU/Linux, lib/stdio.h
includes <stdarg.h> which is why the compile worked for me.
> I think such commits shouldn't happen at all on emacs-25, but on
> master. IMO, the time for cleanups on the release branch has come and
> gone.
The overall commit was needed to port to GCC 4.8 and later with
-fsanitize=address. In hindsight perhaps I should have stuck with the
old non-stdarg API for the newly added diagnostics (on the other hand
perhaps not -- the old API was hard to follow and the confusion caused a
bug in my first version, which is why I changed it).
[-- Attachment #2: 0001-lib-src-make-docfile.c-Include-stdarg.h.patch --]
[-- Type: application/x-patch, Size: 636 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-02-11 21:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-11 7:20 Recent commits break compilation for MinGW64 Fabrice Popineau
2016-02-11 20:40 ` Eli Zaretskii
2016-02-11 21:33 ` Paul Eggert
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).