From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Agustin Martin Newsgroups: gmane.emacs.devel Subject: Re: flyspell bug Date: Wed, 16 Nov 2005 15:22:42 +0000 (UTC) Message-ID: References: <20051031164057.1F82.SLAWOMIR.NOWACZYK.847@student.lu.se> <20051107165012.074E.SLAWOMIR.NOWACZYK.847@student.lu.se> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1132159088 6026 80.91.229.2 (16 Nov 2005 16:38:08 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 16 Nov 2005 16:38:08 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Nov 16 17:38:07 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1EcQDw-000098-IW for ged-emacs-devel@m.gmane.org; Wed, 16 Nov 2005 17:33:29 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EcQDq-0006yn-OC for ged-emacs-devel@m.gmane.org; Wed, 16 Nov 2005 11:33:22 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1EcPH4-00047V-Au for emacs-devel@gnu.org; Wed, 16 Nov 2005 10:32:38 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1EcPH0-00046J-1A for emacs-devel@gnu.org; Wed, 16 Nov 2005 10:32:37 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EcPGz-00045z-2H for emacs-devel@gnu.org; Wed, 16 Nov 2005 10:32:33 -0500 Original-Received: from [80.91.229.2] (helo=ciao.gmane.org) by monty-python.gnu.org with esmtp (TLS-1.0:RSA_AES_128_CBC_SHA:16) (Exim 4.34) id 1EcPGy-0006xo-78 for emacs-devel@gnu.org; Wed, 16 Nov 2005 10:32:32 -0500 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1EcPC6-0000Q5-24 for emacs-devel@gnu.org; Wed, 16 Nov 2005 16:27:30 +0100 Original-Received: from Agmartin.aq.upm.es ([138.100.41.131]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 16 Nov 2005 16:27:30 +0100 Original-Received: from agustin.martin by Agmartin.aq.upm.es with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 16 Nov 2005 16:27:30 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-To: emacs-devel@gnu.org Original-Lines: 33 Original-X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: main.gmane.org User-Agent: Loom/3.14 (http://gmane.org/) X-Loom-IP: 138.100.41.131 (Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.12) Gecko/20050922 Firefox/1.0.7 (Debian package 1.0.7-1)) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:46096 Archived-At: Slawomir Nowaczyk student.lu.se> writes: > But I would prefer to have LocalWords taken care of by ispell -- if > only due to the fact that it should make flyspell-buffer significantly > faster. This should already work with the new localwords patch. > > Besides that, I believe the logic in flyspell-external-point-words > should be simplified significantly -- we should get rid of the "while > keep" loop, just find the first place where > (if (= (length (flyspell-get-word nil)) > (length word)) > and flyspell-word that. I think you need the (while keep) loop for this. > And consider cases where ispell and flyspell > have different ideas about word boundaries to be bugs and fix those. Some of these might require a not found word be signalled by something softer than an error. I am also taking a look at this function making keep nil if any of some conditions is matched. Will send something as soon as looks better (if so), even if still full of debugging code -- Agustin