From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Agustin Martin Newsgroups: gmane.emacs.devel Subject: Re: flyspell bug Date: Fri, 28 Oct 2005 11:11:00 +0000 (UTC) Message-ID: References: <20051013122745.23F5.SLAWOMIR.NOWACZYK.847@student.lu.se> <20051014131718.2403.SLAWOMIR.NOWACZYK.847@student.lu.se> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1130500507 19444 80.91.229.2 (28 Oct 2005 11:55:07 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 28 Oct 2005 11:55:07 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Oct 28 13:55:02 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1EVSmv-0002KV-90 for ged-emacs-devel@m.gmane.org; Fri, 28 Oct 2005 13:52:49 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EVSmu-0000R3-Ov for ged-emacs-devel@m.gmane.org; Fri, 28 Oct 2005 07:52:48 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1EVSAs-0003el-Bb for emacs-devel@gnu.org; Fri, 28 Oct 2005 07:13:30 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1EVSAq-0003ck-2T for emacs-devel@gnu.org; Fri, 28 Oct 2005 07:13:28 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EVSAp-0003cL-9G for emacs-devel@gnu.org; Fri, 28 Oct 2005 07:13:27 -0400 Original-Received: from [80.91.229.2] (helo=ciao.gmane.org) by monty-python.gnu.org with esmtp (TLS-1.0:RSA_AES_128_CBC_SHA:16) (Exim 4.34) id 1EVSAp-00048Q-3x for emacs-devel@gnu.org; Fri, 28 Oct 2005 07:13:27 -0400 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1EVS8t-0007JD-FZ for emacs-devel@gnu.org; Fri, 28 Oct 2005 13:11:27 +0200 Original-Received: from Agmartin.aq.upm.es ([138.100.41.131]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 28 Oct 2005 13:11:27 +0200 Original-Received: from agustin.martin by Agmartin.aq.upm.es with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 28 Oct 2005 13:11:27 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-To: emacs-devel@gnu.org Original-Lines: 42 Original-X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: main.gmane.org User-Agent: Loom/3.14 (http://gmane.org/) X-Loom-IP: 138.100.41.131 (Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.12) Gecko/20050922 Firefox/1.0.7 (Debian package 1.0.7-1)) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:45021 Archived-At: Richard M. Stallman gnu.org> writes: > > When I check it, it is considered a misspelling. Maybe it is in your > personal dictionary? > > That was indeed the reason. Trying it with an empty personal > dictionary, I observed the bug. This patch seems to work; does it > give good results? I have tested that in a sample file and seems to work the same as the old flyspell-external-point-words function from flyspell.el-1.6h (what was present in emacs21.4). That means that works much better than what was previously included in emacs-cvs flyspell.el and in any further flyspell.el version (seemed to be the same code). The only pending problem I see is that mentioned by Piet van Oostrum. Reading the flyspell page seems that trying to fix it was the cause for all those strange double loops, introduced in flyspell.el 1.6i and 1.6j (from Sep 2002). Unfortunately seems that the fix did more harm than good, and never really worked. I am surprised that this has been unnoticed for this long time (since 2002!!) I am adding the relevant flyspell changelog entries, --------------------------------------------------------------------------- Release 1.6j, Fri Sep 20 08:52:00 CEST 2002 (Pasi Ryhanen, Manuel Serrano): *** The fix of 1.6i was actually incorrect. It has thus been stripped off. The new fix iterate over a search word until an actual match is found. Release 1.6i, Thu Sep 19 10:23:12 CEST 2002 (Pasi Ryhanen, Manuel Serrano): *** Improves the performance of flyspell-buffer. The spell checking of the whole buffer is now much faster (many thanks to Pasi). *** Fix a bug in buffer checking. The search for incorrect words was incorrect because flyspell.el was not searching "words" but "strings". The consequence was that if the incorrect word appeared fist, as a prefix of a correct word, it was not highlighted at the location it was misspelled. ----------------------------------------------------------------------------