From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Michael Mauger Newsgroups: gmane.emacs.devel Subject: Re: list-colors-display: display all color names Date: Wed, 29 Dec 2004 14:46:19 +0000 (UTC) Message-ID: References: <87d5wwsuly.fsf@jurta.org> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1104334722 19597 80.91.229.6 (29 Dec 2004 15:38:42 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 29 Dec 2004 15:38:42 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Dec 29 16:38:36 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1CjfuG-0007wV-00 for ; Wed, 29 Dec 2004 16:38:36 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1Cjg59-0005vB-VM for ged-emacs-devel@m.gmane.org; Wed, 29 Dec 2004 10:49:52 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1Cjg4h-0005tp-2d for emacs-devel@gnu.org; Wed, 29 Dec 2004 10:49:23 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1Cjg4f-0005sN-5Z for emacs-devel@gnu.org; Wed, 29 Dec 2004 10:49:21 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1Cjg4f-0005rQ-2b for emacs-devel@gnu.org; Wed, 29 Dec 2004 10:49:21 -0500 Original-Received: from [80.91.229.2] (helo=main.gmane.org) by monty-python.gnu.org with esmtp (Exim 4.34) id 1CjfoX-0005z8-Mn for emacs-devel@gnu.org; Wed, 29 Dec 2004 10:32:42 -0500 Original-Received: from root by main.gmane.org with local (Exim 3.35 #1 (Debian)) id 1CjfoT-0002qx-00 for ; Wed, 29 Dec 2004 16:32:39 +0100 Original-Received: from 158.171.31.18 ([158.171.31.18]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 29 Dec 2004 16:32:37 +0100 Original-Received: from mmaug by 158.171.31.18 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 29 Dec 2004 16:32:37 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-To: emacs-devel@gnu.org Original-Lines: 41 Original-X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: main.gmane.org User-Agent: Loom/3.14 (http://gmane.org/) X-Loom-IP: 158.171.31.18 (Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.0; bkbrel07)) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:31576 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:31576 Juri Linkov jurta.org> writes: > > It's too bad that `list-colors-display' currently doesn't contain > all variants of color names with alternative spellings and spaces. > When I put a color name into the search ring in one buffer and then > isearch it with C-s C-s in the *Colors* buffer to see how the color > looks, often the search fails. I need to edit the search string > to add spaces or change the spelling of color names and to try again. > This is very inconvenient. The *Colors* buffer should contain all > color names, even duplicates with the same color values. > > ... > > This eliminates the need to identify duplicate colors by the name. > I like this idea except for this last bit. We changed `list-colors-display' to match by name rather than color value so that if "System" colors were added to the list they wouldn't be merged together. The examples in the original post are all aliases for the same color. They can be used interchangably on any platform with reasonable results. The System colors are designed to make window manager theme colors available within Emacs so that faces can follow the corresponding colors in the rest of the GUI. If the colors "SystemMenuText" and "SystemText" happen to be mapped to the same color it does not mean that they are aliases for the same color. Under a different window manager theme they might be different colors. In this case these color names are not interchangable and should not be presented as if they were alaises. The comment removed from the code was supposed to explain this clearly. Obviously it did not. Does matching on the name rather than the color value result in a different output with your other changes? Should we match on color value unless the name starts with the string "System"? -- Michael Mauger