From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jari Aalto Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] autorevert.el -- revert fix for Windows platform Date: 23 Mar 2007 09:03:20 +0200 Organization: Private Message-ID: References: <7it9frhi.fsf@cante.net> <87slbx9vcf.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1174633458 29120 80.91.229.12 (23 Mar 2007 07:04:18 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 23 Mar 2007 07:04:18 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Mar 23 08:04:10 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HUdoh-0006JP-8h for ged-emacs-devel@m.gmane.org; Fri, 23 Mar 2007 08:04:04 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HUdqY-0002do-AE for ged-emacs-devel@m.gmane.org; Fri, 23 Mar 2007 02:05:58 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HUdqV-0002bR-Nx for emacs-devel@gnu.org; Fri, 23 Mar 2007 03:05:55 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HUdqU-0002Zj-U2 for emacs-devel@gnu.org; Fri, 23 Mar 2007 03:05:55 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HUdqU-0002ZY-R5 for emacs-devel@gnu.org; Fri, 23 Mar 2007 02:05:54 -0500 Original-Received: from main.gmane.org ([80.91.229.2] helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1HUdoa-00064o-M4 for emacs-devel@gnu.org; Fri, 23 Mar 2007 03:03:57 -0400 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1HUdoI-0007YQ-DO for emacs-devel@gnu.org; Fri, 23 Mar 2007 08:03:39 +0100 Original-Received: from a81-197-175-198.elisa-laajakaista.fi ([81.197.175.198]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 23 Mar 2007 08:03:38 +0100 Original-Received: from jari.aalto by a81-197-175-198.elisa-laajakaista.fi with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 23 Mar 2007 08:03:38 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 24 Original-X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: a81-197-175-198.elisa-laajakaista.fi User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3 X-detected-kernel: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:68358 Archived-At: Chong Yidong writes: > Jari Aalto writes: > > > For some reason the `verify-visited-file-modtime' test in > > auto-revert-buffers is not enough to notice a file change under > > Windows / native Emacs 21.3. Here is patch to compare the bufer size > > against files size on disk. It cures the revert problem. > > That's not foolproof, since changes need not alter the file size. True. Do you know any use case of such a situation? > Could you try to find out why verify-visited-file-modtime doesn't > work on Windows? You said that the problem exists on Emacs 21---does > it still exist under Emacs 22? I could test more if you point me to a location where I can download native windows version of 22.x I downloaded only the lisp code from CVS to submit a patch that would apply cleanly. Jari