* Re: master 222a7a1 1/2: Flag checkdoc-symbol-words as a :safe variable
[not found] ` <20210919111928.5BBFD20ABE@vcs0.savannah.gnu.org>
@ 2021-09-19 17:19 ` Glenn Morris
2021-09-19 20:42 ` Stefan Kangas
0 siblings, 1 reply; 3+ messages in thread
From: Glenn Morris @ 2021-09-19 17:19 UTC (permalink / raw)
To: emacs-devel; +Cc: Stefan Kangas
> branch: master
> commit 222a7a1a8afdf6921e5981133c605c2d695e9281
> Flag checkdoc-symbol-words as a :safe variable
> --- a/lisp/emacs-lisp/checkdoc.el
> +++ b/lisp/emacs-lisp/checkdoc.el
> @@ -320,6 +320,7 @@ with a universal argument.")
> These words are ignored when unquoted symbols are searched for.
> This should be set in an Emacs Lisp file's local variables."
> :type '(repeat (string :tag "Word"))
> + :safe #'listp
> :version "28.1")
> ;;;###autoload(put 'checkdoc-symbol-words 'safe-local-variable #'checkdoc-list-of-strings-p)
checkdoc-symbol-words already had a safe-local-variable property
(last line of the context above).
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: master 222a7a1 1/2: Flag checkdoc-symbol-words as a :safe variable
2021-09-19 17:19 ` master 222a7a1 1/2: Flag checkdoc-symbol-words as a :safe variable Glenn Morris
@ 2021-09-19 20:42 ` Stefan Kangas
2021-09-19 23:25 ` Stefan Monnier
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Kangas @ 2021-09-19 20:42 UTC (permalink / raw)
To: Glenn Morris, emacs-devel
Glenn Morris <rgm@gnu.org> writes:
> checkdoc-symbol-words already had a safe-local-variable property
> (last line of the context above).
Thanks. Not sure how I missed that, but this is now reverted on master.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: master 222a7a1 1/2: Flag checkdoc-symbol-words as a :safe variable
2021-09-19 20:42 ` Stefan Kangas
@ 2021-09-19 23:25 ` Stefan Monnier
0 siblings, 0 replies; 3+ messages in thread
From: Stefan Monnier @ 2021-09-19 23:25 UTC (permalink / raw)
To: Stefan Kangas; +Cc: Glenn Morris, emacs-devel
>> checkdoc-symbol-words already had a safe-local-variable property
>> (last line of the context above).
> Thanks. Not sure how I missed that, but this is now reverted on master.
Side note: `listp` is rarely a precise enough predicate for
a variable's safety.
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-09-19 23:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20210919111926.21685.76222@vcs0.savannah.gnu.org>
[not found] ` <20210919111928.5BBFD20ABE@vcs0.savannah.gnu.org>
2021-09-19 17:19 ` master 222a7a1 1/2: Flag checkdoc-symbol-words as a :safe variable Glenn Morris
2021-09-19 20:42 ` Stefan Kangas
2021-09-19 23:25 ` Stefan Monnier
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).