From: Miguel Guedes <miguel.a.guedes@gmail.com>
To: emacs-devel@gnu.org
Subject: Re: process.c: read_process_output: hard coded 4096 bytes read limit
Date: Sun, 23 Jun 2013 08:59:11 +0000 (UTC) [thread overview]
Message-ID: <kq6dcu$mlm$1@ger.gmane.org> (raw)
In-Reply-To: 51C5DE9B.8010607@cs.ucla.edu
On Sat, 22 Jun 2013 10:27:55 -0700, Paul Eggert wrote:
> I don't know, and that limit has bothered me in the past, too.
>
> It's a simple matter to increase it to 16 K bytes; does the patch below
> help your performance? If so, I can install it. Letting the user
> specify a larger limit might make sense, but would take a bit of thought
> and hacking.
>
Thank you for your reply, Paul!
I am unable to apply and test the patch at the moment but I'm sure it
will help with performance, though not entirely fix it. I have this
minor mode that I'm developing that receives code completion data
asynchronously from a server bound to localhost. The actual server side
processing of code completion always takes less than 100ms and the
results are sent to the client in full. It is then ironic (as well as
frustrating) that the bottleneck (latency lasting many seconds) I'm
experiencing is being caused by emacs when just receiving the raw data
before even any processing takes place in the client side (which is very
fast anyway)!
There are a couple of ways I can use to mitigate the latency issues
mentioned above so I already have a fix, however IMHO there is a problem
in the way emacs reads data from process channels that needs to be fixed,
which I wouldn't mind contributing to. I assume you're an active emacs
developer (my own knowledge of emacs' internal code and architecture is
extremely limited), how would you tackle this, Paul?
Apart from raising the hardcoded limit, one (perhaps simpler) way would
be to allow the user to specify the buffer size when spawning a process/
network connection, however that still leaves open the problem of the
waits between reads. So perhaps the best strategy to fix this, though
probably more complicated, would be to tackle the waits between reads
head on? How problematic with this be?
Apologies for not understanding but by "I can install it", did you mean
you can commit it?
next prev parent reply other threads:[~2013-06-23 8:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-22 10:05 process.c: read_process_output: hard coded 4096 bytes read limit Miguel Guedes
2013-06-22 17:27 ` Paul Eggert
2013-06-23 8:59 ` Miguel Guedes [this message]
2013-06-23 9:28 ` Andreas Schwab
2013-06-25 8:20 ` Miguel Guedes
2013-06-26 11:57 ` Thien-Thi Nguyen
2013-06-26 13:16 ` Stefan Monnier
2013-06-27 6:03 ` Thien-Thi Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='kq6dcu$mlm$1@ger.gmane.org' \
--to=miguel.a.guedes@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).