From: Glenn Morris <rgm@gnu.org>
To: Alan Mackenzie <acm@muc.de>
Cc: emacs-devel@gnu.org
Subject: Re: master 1ca436a: Make compilation mode work with warnings from compiled buffer functions
Date: Wed, 28 Nov 2018 22:51:02 -0500 [thread overview]
Message-ID: <k5bm68pmmx.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <20181128201600.GA5331@ACM> (Alan Mackenzie's message of "Wed, 28 Nov 2018 20:16:00 +0000")
Alan Mackenzie wrote:
> The previous version of bytecomp.el used at least one function in
> compile.el (namely compilation-mode), suggesting that compile.elc? is
> already loaded when bytecomp starts.
It only uses compilation-mode in interactive use, but 1ca436a33c loads
compile unconditionally.
> However, for some fiddly reason a macro in compile.el was no longer
> defined, hence the require.
Since AFAICS you only need the define-compilation-mode macro,
eval-when-compile should solve the slowdown.
next prev parent reply other threads:[~2018-11-29 3:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20181128132417.30869.1170@vcs0.savannah.gnu.org>
[not found] ` <20181128132418.851A9204F1@vcs0.savannah.gnu.org>
2018-11-28 16:37 ` master 1ca436a: Make compilation mode work with warnings from compiled buffer functions Glenn Morris
2018-11-28 20:16 ` Alan Mackenzie
2018-11-29 3:51 ` Glenn Morris [this message]
2018-11-29 10:26 ` Alan Mackenzie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=k5bm68pmmx.fsf@fencepost.gnu.org \
--to=rgm@gnu.org \
--cc=acm@muc.de \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).