Re: abbrev table in cperl-mode

[Leo <sdl.web@googlemail.com>]

[-- Attachment #1: Type: text/plain, Size: 2197 bytes --]

On 16 April 2010 20:12, Ilya Zakharevich <ilya@math.berkeley.edu> wrote:
> On Fri, Apr 16, 2010 at 12:27:05PM +0100, Leo wrote:
>> Hello Ilya,
>>
>> Is it intended for the abbrevs defined in cperl-mode to be saved to the
>> abbrev file i.e. these:
>>
>> ......
>> (let ((prev-a-c abbrevs-changed))
>>     (define-abbrev-table 'cperl-mode-abbrev-table '(
>>               ("if" "if" cperl-electric-keyword 0)
>>               ("elsif" "elsif" cperl-electric-keyword 0)
>>               ("while" "while" cperl-electric-keyword 0)
>>               ("until" "until" cperl-electric-keyword 0)
>>               ("unless" "unless" cperl-electric-keyword 0)
>>               ("else" "else" cperl-electric-else 0)
>>               ("continue" "continue" cperl-electric-else 0)
>>               ("for" "for" cperl-electric-keyword 0)
>>               ("foreach" "foreach" cperl-electric-keyword 0)
>>               ("formy" "formy" cperl-electric-keyword 0)
>>               ("foreachmy" "foreachmy" cperl-electric-keyword 0)
>>               ("do" "do" cperl-electric-keyword 0)
>>               ("=pod" "=pod" cperl-electric-pod 0)
>>               ("=over" "=over" cperl-electric-pod 0)
>>               ("=head1" "=head1" cperl-electric-pod 0)
>>               ("=head2" "=head2" cperl-electric-pod 0)
>>               ("pod" "pod" cperl-electric-pod 0)
>>               ("over" "over" cperl-electric-pod 0)
>>               ("head1" "head1" cperl-electric-pod 0)
>>               ("head2" "head2" cperl-electric-pod 0)))
>>       (setq abbrevs-changed prev-a-c))
>> ......
>>
>> It seems a bit better to define them as system abbrevs.
>
> I trust your word for this.  ;-)  What you see is the "I implemented
> it the way I could - given my very limited understanding of
> abbreviation tables" approach.

Generally I think program should define system abbrevs to
differentiate from abbrevs defined by the user. And each time
define-abbrev-* runs, the abbrev definitions are overwritten anyway.

The attached patch does this. BTW, defining system abbrevs doesn't
change abbrev-changed so I leave the (let ...) out.

> Try to educate me more,
> Ilya

Leo

[-- Attachment #2: 0001-Fix-cperl-mode-abbrevs.patch --]
[-- Type: application/octet-stream, Size: 2869 bytes --]

From 45bee4e80314563243b71a710beaae7a2d8ece26 Mon Sep 17 00:00:00 2001
From: Leo <sdl.web@gmail.com>
Date: Fri, 16 Apr 2010 21:09:01 +0100
Subject: [PATCH] Fix cperl-mode abbrevs

---
 lisp/progmodes/cperl-mode.el |   44 ++++++++++++++++++++---------------------
 1 files changed, 21 insertions(+), 23 deletions(-)

diff --git a/lisp/progmodes/cperl-mode.el b/lisp/progmodes/cperl-mode.el
index 2f751f2..10d5bf3 100644
--- a/lisp/progmodes/cperl-mode.el
+++ b/lisp/progmodes/cperl-mode.el
@@ -1714,29 +1714,27 @@ or as help on variables `cperl-tips', `cperl-problems',
 			  [(control c) (control h) f])))
   (setq major-mode cperl-use-major-mode)
   (setq mode-name "CPerl")
-  (let ((prev-a-c abbrevs-changed))
-    (define-abbrev-table 'cperl-mode-abbrev-table '(
-		("if" "if" cperl-electric-keyword 0)
-		("elsif" "elsif" cperl-electric-keyword 0)
-		("while" "while" cperl-electric-keyword 0)
-		("until" "until" cperl-electric-keyword 0)
-		("unless" "unless" cperl-electric-keyword 0)
-		("else" "else" cperl-electric-else 0)
-		("continue" "continue" cperl-electric-else 0)
-		("for" "for" cperl-electric-keyword 0)
-		("foreach" "foreach" cperl-electric-keyword 0)
-		("formy" "formy" cperl-electric-keyword 0)
-		("foreachmy" "foreachmy" cperl-electric-keyword 0)
-		("do" "do" cperl-electric-keyword 0)
-		("=pod" "=pod" cperl-electric-pod 0)
-		("=over" "=over" cperl-electric-pod 0)
-		("=head1" "=head1" cperl-electric-pod 0)
-		("=head2" "=head2" cperl-electric-pod 0)
-		("pod" "pod" cperl-electric-pod 0)
-		("over" "over" cperl-electric-pod 0)
-		("head1" "head1" cperl-electric-pod 0)
-		("head2" "head2" cperl-electric-pod 0)))
-	(setq abbrevs-changed prev-a-c))
+  (define-abbrev-table 'cperl-mode-abbrev-table
+    '(("if" "if" cperl-electric-keyword 0 t)
+      ("elsif" "elsif" cperl-electric-keyword 0 t)
+      ("while" "while" cperl-electric-keyword 0 t)
+      ("until" "until" cperl-electric-keyword 0 t)
+      ("unless" "unless" cperl-electric-keyword 0 t)
+      ("else" "else" cperl-electric-else 0 t)
+      ("continue" "continue" cperl-electric-else 0 t)
+      ("for" "for" cperl-electric-keyword 0 t)
+      ("foreach" "foreach" cperl-electric-keyword 0 t)
+      ("formy" "formy" cperl-electric-keyword 0 t)
+      ("foreachmy" "foreachmy" cperl-electric-keyword 0 t)
+      ("do" "do" cperl-electric-keyword 0 t)
+      ("=pod" "=pod" cperl-electric-pod 0 t)
+      ("=over" "=over" cperl-electric-pod 0 t)
+      ("=head1" "=head1" cperl-electric-pod 0 t)
+      ("=head2" "=head2" cperl-electric-pod 0 t)
+      ("pod" "pod" cperl-electric-pod 0 t)
+      ("over" "over" cperl-electric-pod 0 t)
+      ("head1" "head1" cperl-electric-pod 0 t)
+      ("head2" "head2" cperl-electric-pod 0 t)))
   (setq local-abbrev-table cperl-mode-abbrev-table)
   (if (cperl-val 'cperl-electric-keywords)
       (abbrev-mode 1))
-- 
1.7.0.4