unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Emacs Devel <emacs-devel@gnu.org>
Subject: Re: dirtrack-toggle () vs. shell-dirtrack-mode (&optional arg)
Date: Thu, 18 May 2006 13:46:36 -0400	[thread overview]
Message-ID: <jwvzmhfns9n.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <f7ccd24b0605180245o118d7cfct70ca2e812cb1fd26@mail.gmail.com> (Juanma Barranquero's message of "Thu, 18 May 2006 11:45:27 +0200")

> After this:
> 2006-05-17  Stefan Monnier  <monnier@iro.umontreal.ca>

>        * shell.el (shell-dirtrack-mode): Make it into a proper minor mode, so
>        we can explicitly enable/disable rather than toggle.

> `dirtrack-toggle' is an alias to
>   shell-dirtrack-mode (&optional arg)
> in shell.el, and a function
>   dirtrack-toggle ()
> in dirtrack.el. Harmless, but it does generate a warning when compiling:

Hmm... so there were two definitions which happened to have the same number
of arguments so the byte-compiler never complained whereas now that the two
defs have different number of args the compiler complains.

I think the problem is that we have two definitions.  I suggest we remove
the dirtrack-toggle alias in shell.el.  This function has plenty of other
aliases already.


        Stefan

  reply	other threads:[~2006-05-18 17:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-18  9:45 dirtrack-toggle () vs. shell-dirtrack-mode (&optional arg) Juanma Barranquero
2006-05-18 17:46 ` Stefan Monnier [this message]
2006-05-18 17:51   ` Juanma Barranquero

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvzmhfns9n.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).