From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Jason Rumney <jasonr@gnu.org>
Cc: Eli Zaretskii <eliz@gnu.org>, Jari Aalto <jari.aalto@cante.net>,
emacs-devel@gnu.org, "Kim F. Storm" <storm@cua.dk>
Subject: Re: [PATCH] autorevert.el -- revert fix for Windows platform
Date: Fri, 23 Mar 2007 18:41:35 -0400 [thread overview]
Message-ID: <jwvzm634m8y.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <46040576.9090505@gnu.org> (Jason Rumney's message of "Fri\, 23 Mar 2007 16\:51\:02 +0000")
>> For the release, I'd say Jari's patch is good enough!
> I'm not sure, do we really expect buffer-size to be the same as the number
> of bytes in the file, potentially in the presence of multibyte characters?
> This change is quite likely to break things if that assumption is
> not correct.
Duh, I didn't even look at the patch. So no clearly the patch is
unacceptable as is. But the principle of checking whether the file changes
size is the thing I agreed to.
Stefan
next prev parent reply other threads:[~2007-03-23 22:41 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-22 11:27 [PATCH] autorevert.el -- revert fix for Windows platform Jari Aalto
2007-03-22 15:00 ` Chong Yidong
2007-03-22 15:56 ` Lennart Borgman (gmail)
2007-03-22 17:49 ` Jason Rumney
2007-03-23 13:26 ` Eli Zaretskii
2007-03-23 17:31 ` Jari Aalto
2007-03-23 20:36 ` Jason Rumney
2007-03-23 23:07 ` Jason Rumney
2007-03-24 10:52 ` martin rudalics
2007-03-24 11:11 ` Jason Rumney
2007-03-24 11:25 ` Johan Bockgård
2007-03-24 11:46 ` Jason Rumney
2007-03-24 11:32 ` martin rudalics
2007-03-24 18:21 ` Eli Zaretskii
2007-03-24 22:56 ` Kim F. Storm
2007-03-25 4:13 ` Eli Zaretskii
2007-03-24 14:46 ` Eli Zaretskii
2007-03-23 7:03 ` Jari Aalto
2007-03-23 14:10 ` Eli Zaretskii
2007-03-23 15:47 ` Kim F. Storm
2007-03-23 16:51 ` Jason Rumney
2007-03-23 18:48 ` Luc Teirlinck
2007-03-24 14:59 ` Eli Zaretskii
2007-03-23 22:41 ` Stefan Monnier [this message]
2007-03-24 23:50 ` Kim F. Storm
2007-03-25 0:24 ` Luc Teirlinck
2007-03-25 1:09 ` Kim F. Storm
2007-03-25 19:09 ` Stefan Monnier
2007-03-23 16:57 ` Stefan Monnier
2007-03-24 14:49 ` Eli Zaretskii
2007-03-23 13:25 ` Eli Zaretskii
2007-03-22 22:50 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvzm634m8y.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=jari.aalto@cante.net \
--cc=jasonr@gnu.org \
--cc=storm@cua.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).