From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: vc-find-root does not work for non-existent file argument Date: Mon, 23 Jul 2007 01:38:55 -0400 Message-ID: References: <200707160050.l6G0oxfm014234@oogie-boogie.ics.uci.edu> <200707201756.l6KHu2MO020412@oogie-boogie.ics.uci.edu> <200707211659.l6LGxo7m017360@oogie-boogie.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1185169148 15363 80.91.229.12 (23 Jul 2007 05:39:08 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 23 Jul 2007 05:39:08 +0000 (UTC) Cc: emacs-devel@gnu.org To: Dan Nicolaescu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jul 23 07:39:04 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1ICqdK-0007ho-RG for ged-emacs-devel@m.gmane.org; Mon, 23 Jul 2007 07:39:03 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ICqdK-0000h0-9u for ged-emacs-devel@m.gmane.org; Mon, 23 Jul 2007 01:39:02 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1ICqdH-0000gp-6I for emacs-devel@gnu.org; Mon, 23 Jul 2007 01:38:59 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1ICqdE-0000gT-PG for emacs-devel@gnu.org; Mon, 23 Jul 2007 01:38:57 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ICqdE-0000gQ-JV for emacs-devel@gnu.org; Mon, 23 Jul 2007 01:38:56 -0400 Original-Received: from bc.sympatico.ca ([209.226.175.184] helo=tomts22-srv.bellnexxia.net) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1ICqdE-0000V3-7K for emacs-devel@gnu.org; Mon, 23 Jul 2007 01:38:56 -0400 Original-Received: from pastel.home ([70.53.194.155]) by tomts22-srv.bellnexxia.net (InterMail vM.5.01.06.13 201-253-122-130-113-20050324) with ESMTP id <20070723053855.LKPG18413.tomts22-srv.bellnexxia.net@pastel.home> for ; Mon, 23 Jul 2007 01:38:55 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 10A1680DB; Mon, 23 Jul 2007 01:38:54 -0400 (EDT) In-Reply-To: <200707211659.l6LGxo7m017360@oogie-boogie.ics.uci.edu> (Dan Nicolaescu's message of "Sat\, 21 Jul 2007 09\:59\:49 -0700") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1.50 (gnu/linux) X-detected-kernel: Solaris 8 (1) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:75360 Archived-At: >> >> > If FILE that is managed using either hg or bzr (both of which use >> >> > vc-find-root) is deleted, doing C-x C-f FILE RET after that will not >> >> > result emacs asking the question: "File FILE was lost; check out from >> >> > version control? " >> >> >> >> > The reason is that (vc-find-root FILE BLAH) returns nil, so VC thinks >> >> > that FILE is not under version control. >> >> > vc-find-root returns nil because of the way the result of >> >> > file-attributes is used... >> >> >> >> I believe this is fixed now, but there seem to be a related problem left >> >> over, ... working on it, >> >> > Is the issue you are still looking at something like this: >> >> > mkdir -p /tmp/foo/bar >> >> > (vc-find-root "/tmp/foo/" "bar") => nil (instead of t)? >> >> Yes, and I believe it is fixed now, > Can you please fix it on the 22.2 branch too? Done, Stefan