From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: VC commit missing ChangeLog message Date: Wed, 12 Nov 2008 20:56:40 -0500 Message-ID: References: <86ej1il3z7.fsf@lifelogs.com> <1226414985.525611.2969.nullmailer@null> <8663mukybp.fsf@lifelogs.com> <200811111658.mABGwYR1004191@mothra.ics.uci.edu> <86myg6hycx.fsf@lifelogs.com> <200811111945.mABJjWvA004946@mothra.ics.uci.edu> <86od0mgcz5.fsf@lifelogs.com> <200811120111.mAC1B6h1005596@mothra.ics.uci.edu> <86tzacg8yc.fsf@lifelogs.com> <86abc4fwfu.fsf@lifelogs.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1226541429 11230 80.91.229.12 (13 Nov 2008 01:57:09 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 13 Nov 2008 01:57:09 +0000 (UTC) Cc: emacs-devel@gnu.org To: Ted Zlatanov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Nov 13 02:58:10 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1L0RTE-0008DV-AV for ged-emacs-devel@m.gmane.org; Thu, 13 Nov 2008 02:58:08 +0100 Original-Received: from localhost ([127.0.0.1]:52469 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L0RS5-00020O-Ti for ged-emacs-devel@m.gmane.org; Wed, 12 Nov 2008 20:56:57 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L0RS1-000204-9j for emacs-devel@gnu.org; Wed, 12 Nov 2008 20:56:53 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L0RRw-0001zZ-T3 for emacs-devel@gnu.org; Wed, 12 Nov 2008 20:56:52 -0500 Original-Received: from [199.232.76.173] (port=54998 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L0RRw-0001zV-PS for emacs-devel@gnu.org; Wed, 12 Nov 2008 20:56:48 -0500 Original-Received: from ironport2-out.pppoe.ca ([206.248.154.182]:32430 helo=ironport2-out.teksavvy.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1L0RRw-0005Et-I8 for emacs-devel@gnu.org; Wed, 12 Nov 2008 20:56:48 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApwEAEsXG0lFxLQU/2dsb2JhbACBds4/g1eBEQ X-IronPort-AV: E=Sophos;i="4.33,593,1220241600"; d="scan'208";a="29802861" Original-Received: from 69-196-180-20.dsl.teksavvy.com (HELO pastel.home) ([69.196.180.20]) by ironport2-out.teksavvy.com with ESMTP; 12 Nov 2008 20:56:42 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 1F1B784CE; Wed, 12 Nov 2008 20:56:40 -0500 (EST) In-Reply-To: <86abc4fwfu.fsf@lifelogs.com> (Ted Zlatanov's message of "Wed, 12 Nov 2008 15:47:49 -0600") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:105622 Archived-At: >>> I see your point and agree. How about this patch to just call >>> log-edit-insert-changelog? I call it regardless of the SETUP parameter, >>> but it could follow the erase-buffer call instead. SM> I'd rather just change the default value of the hook, so that users can SM> remove that entry from the hook if they don't want it run. > Wait, the hook already calls it. For me it doesn't work, though (which > is why I started this thread). Something is breaking in the changelog > entry detection logic. It worked when I did C-c C-a (without C-u) > manually. It must have been the logic that applies C-u if C-c C-a is > called twice in a row; I must have hit the key twice without realizing > it. So the problem is actually that the default logic doesn't detect my > ChangeLog entry, not that log-edit-insert-changelog is not called. Argh. It's probably the `setup' argument together with the log-edit-invert-setup confg variable. It's rather messy and the main purpose was to preserve 100% behavioral-compatibility while introducing new features. But I think I agree that the setup should simply always happen and the user can then use the log-edit-hook to control what kind of setup he wants to take place. Stefan