From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Sam Steingold <sds@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r109160: * lisp/vc/vc-dispatcher.el (vc-compilation-mode): Add, based on
Date: Thu, 19 Jul 2012 18:00:44 -0400 [thread overview]
Message-ID: <jwvzk6vquqg.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <E1SrsTu-0003A3-UQ@vcs.savannah.gnu.org> (Sam Steingold's message of "Thu, 19 Jul 2012 10:38:01 -0400")
Could you explain this patch?
I do not understand what it's trying to do. Using compilation-mode on
the output of those tools doesn't sound very useful. What's the use-case?
Stefan
> + (let* ((error-regexp-alist
> + (vc-make-backend-sym backend 'error-regexp-alist))
> + (compilation-error-regexp-alist
> + (and (boundp error-regexp-alist)
> + (symbol-value error-regexp-alist))))
This is clearly wrong: error-regexp-alist seems to be meant to hold
a symbol, but its name implies it should hold an alist.
next parent reply other threads:[~2012-07-19 22:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1SrsTu-0003A3-UQ@vcs.savannah.gnu.org>
2012-07-19 22:00 ` Stefan Monnier [this message]
2012-07-20 2:09 ` [Emacs-diffs] /srv/bzr/emacs/trunk r109160: * lisp/vc/vc-dispatcher.el (vc-compilation-mode): Add, based on Sam Steingold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvzk6vquqg.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=sds@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).