From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: fix for bug 10994 breaks ido customizations in major way Date: Tue, 07 May 2013 17:18:30 -0400 Message-ID: References: <87txmfyb9n.fsf@gmail.com> <87vc6vulvo.fsf@gmail.com> <87a9o7rsan.fsf@wanadoo.es> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; CHARSET=US-ASCII Content-Transfer-Encoding: 7BIT X-Trace: ger.gmane.org 1367961525 20354 80.91.229.3 (7 May 2013 21:18:45 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 7 May 2013 21:18:45 +0000 (UTC) Cc: Leo Liu , emacs-devel@gnu.org To: Le Wang Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 07 23:18:44 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UZpHU-00074Q-7K for ged-emacs-devel@m.gmane.org; Tue, 07 May 2013 23:18:40 +0200 Original-Received: from localhost ([::1]:42006 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZpHT-00066c-Pl for ged-emacs-devel@m.gmane.org; Tue, 07 May 2013 17:18:39 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:45773) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZpHP-00066R-Li for emacs-devel@gnu.org; Tue, 07 May 2013 17:18:37 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UZpHL-0007IC-3k for emacs-devel@gnu.org; Tue, 07 May 2013 17:18:35 -0400 Original-Received: from relais.videotron.ca ([24.201.245.36]:55689) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZpHK-0007I7-VP for emacs-devel@gnu.org; Tue, 07 May 2013 17:18:31 -0400 Original-Received: from ceviche.home ([24.201.208.110]) by VL-VM-MR006.ip.videotron.ca (Oracle Communications Messaging Exchange Server 7u4-22.01 64bit (built Apr 21 2011)) with ESMTP id <0MMG00EKZ5UUMBD0@VL-VM-MR006.ip.videotron.ca> for emacs-devel@gnu.org; Tue, 07 May 2013 17:18:30 -0400 (EDT) Original-Received: by ceviche.home (Postfix, from userid 20848) id 1241B66107; Tue, 07 May 2013 17:18:30 -0400 (EDT) In-reply-to: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 24.201.245.36 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:159408 Archived-At: > Leo, can we wrap this up please? > My last patch > a) is fast > b) fixes the bug as reported by the user (10994) > c) does not break existing functionality packages rely on > d) does not facilitate creating confusing UI in future > Seems like a win to me, but please discuss further if there are other > considerations. Supporting multiple options with same text is not very important, given the tendency to confusion, so I think your patch is a good idea. Stefan