From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Simple lisp-tests.el and commit privs Date: Tue, 20 Aug 2013 01:23:42 -0400 Message-ID: References: <87y584c6gv.fsf@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1376976246 7626 80.91.229.3 (20 Aug 2013 05:24:06 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 20 Aug 2013 05:24:06 +0000 (UTC) Cc: Dmitry Gutov , emacs-devel@gnu.org To: Barry OReilly Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Aug 20 07:24:08 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VBeQJ-0008CE-9o for ged-emacs-devel@m.gmane.org; Tue, 20 Aug 2013 07:24:07 +0200 Original-Received: from localhost ([::1]:46000 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VBeQI-00052U-P9 for ged-emacs-devel@m.gmane.org; Tue, 20 Aug 2013 01:24:06 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48345) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VBeQ7-00052A-I6 for emacs-devel@gnu.org; Tue, 20 Aug 2013 01:24:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VBeQ0-0000Nz-8S for emacs-devel@gnu.org; Tue, 20 Aug 2013 01:23:55 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:20837) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VBeQ0-0000Nt-3s for emacs-devel@gnu.org; Tue, 20 Aug 2013 01:23:48 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EABK/CFHO+LNT/2dsb2JhbABEvw4Xc4IeAQEEAVYjEAs0EhQYDSSIHgaxH5AOkQoDpHqBXoMT X-IPAS-Result: Av4EABK/CFHO+LNT/2dsb2JhbABEvw4Xc4IeAQEEAVYjEAs0EhQYDSSIHgaxH5AOkQoDpHqBXoMT X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="22578342" Original-Received: from 206-248-179-83.dsl.teksavvy.com (HELO fmsmemgm.homelinux.net) ([206.248.179.83]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 20 Aug 2013 01:23:38 -0400 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 72854AE0CA; Tue, 20 Aug 2013 01:23:42 -0400 (EDT) In-Reply-To: (Barry OReilly's message of "Mon, 19 Aug 2013 12:41:20 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.182 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:162904 Archived-At: >>> It looks like the test/indent tests are only good for null-diff >>> general indentation rules. >> What makes you think so? > When the diff outputs differences (ie a non null-diff), how does the > current test/indent distinguish expected from unexpected? If there > was a test/indent/ruby.rb.expected file (for example), then I could > see how it could do so: 'diff ruby.rb.expected ruby.rb.new' returns > nothing. Oh, you're referring to known indentation problems, where you want to have the test but have it be marked as "expected". Yes, that's currently not really supported: I try to put "FIXME" on the corresponding lines, but very often an incorrect indentation on one line impact subsequent lines as well, so not only does the "diff" not care about those FIXME markers, but you can get false positives or false negatives to boot. Stefan