From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Leo Liu <sdl.web@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
Subject: Re: Eldoc mode in eval-minibuffer
Date: Mon, 20 Jan 2014 21:05:44 -0500 [thread overview]
Message-ID: <jwvzjmq3xma.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <m1bnz686i6.fsf@gmail.com> (Leo Liu's message of "Tue, 21 Jan 2014 09:32:01 +0800")
> But previously it was enabled only after loading eldoc.el via add-hook
> to eval-expression-minibuffer-setup-hook.
> But then someone added a FIXME on that add-hook.
Ah, that rings a bell, I was that someone.
> While discarding the eldoc-post-insert-mode I thought I get rid of that
> FIXME as well. Who would know someone would complain? ;)
I think the way to get rid of that FIXME is to remove the `add-hook'
but without replacing it with a mandatory call to eldoc-mode in
read--expression.
As for how to best enable eldoc-mode in the minibuffer, it's a good
question. If the user enables (a hypothetical) global-eldoc-mode, then
read--expression could check global-eldoc-mode to decide whether to
enable eldoc-mode.
Stefan
next prev parent reply other threads:[~2014-01-21 2:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-20 16:02 Eldoc mode in eval-minibuffer Eli Zaretskii
2014-01-20 17:48 ` Thierry Volpiatto
2014-01-21 1:23 ` Leo Liu
2014-01-21 1:42 ` Leo Liu
2014-01-21 9:52 ` Thierry Volpiatto
2014-01-21 13:41 ` Stefan Monnier
2014-01-21 13:35 ` Stefan Monnier
2014-01-20 17:59 ` Stefan Monnier
2014-01-20 19:25 ` Eli Zaretskii
2014-01-20 19:47 ` Glenn Morris
2014-01-21 1:32 ` Leo Liu
2014-01-21 2:05 ` Stefan Monnier [this message]
2014-01-21 2:24 ` Leo Liu
2014-01-22 10:28 ` Darren Hoo
2014-01-22 13:41 ` Stefan Monnier
2014-01-21 3:45 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvzjmq3xma.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=sdl.web@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).