From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Freezing frameset-restore Date: Sat, 08 Mar 2014 09:27:29 -0500 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1394288860 23752 80.91.229.3 (8 Mar 2014 14:27:40 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 8 Mar 2014 14:27:40 +0000 (UTC) Cc: Emacs developers To: Juanma Barranquero Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Mar 08 15:27:48 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WMIE7-0002f6-1J for ged-emacs-devel@m.gmane.org; Sat, 08 Mar 2014 15:27:47 +0100 Original-Received: from localhost ([::1]:40791 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WMIE6-00074x-Ki for ged-emacs-devel@m.gmane.org; Sat, 08 Mar 2014 09:27:46 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47836) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WMIDw-00074e-Sy for emacs-devel@gnu.org; Sat, 08 Mar 2014 09:27:44 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WMIDp-0006th-KC for emacs-devel@gnu.org; Sat, 08 Mar 2014 09:27:36 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:42696) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WMIDp-0006tc-GM for emacs-devel@gnu.org; Sat, 08 Mar 2014 09:27:29 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EABK/CFFMCppy/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLDiYSFBgNJIgeBsEtkQoDiGGcGYFegxU X-IPAS-Result: Av4EABK/CFFMCppy/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLDiYSFBgNJIgeBsEtkQoDiGGcGYFegxU X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="50869965" Original-Received: from 76-10-154-114.dsl.teksavvy.com (HELO ceviche.home) ([76.10.154.114]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 08 Mar 2014 09:27:28 -0500 Original-Received: by ceviche.home (Postfix, from userid 20848) id 2702E660A5; Sat, 8 Mar 2014 09:27:29 -0500 (EST) In-Reply-To: (Juanma Barranquero's message of "Sat, 8 Mar 2014 07:00:03 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:170227 Archived-At: >> Clearly, the returned list does not need to give an action for >> all frames. Only for those which we did consider. So we don't need to >> call `frames-list' just so as to build the return value. > I'm not sure what do you mean here by "those which we did consider" The function returns the frames that it considered and what action it took with it. It will not necessarily return an entry for each existing frame. > any case, I suspect that I strongly disagree. For example, you could > pass REUSE-FRAMES = :none, which wouldn't "consider" any existing > frame at all, and yet want to delete all previously-existing frames. I don't see why that would be problem. The returned list simply wouldn't mention any of the existing frames, so if you want to delete those you'll have to call `frame-list'. > And even in our scarce two uses cases, already one of them > (frameset--jump-to-register) does need a cleanup other than > delete-frame, because its default action (copied from > frame-configuration-to-register) is to iconify. Look at it not as "move stuff from frameset-restore to its caller" but as "split frameset-restore into two functions". Stefan