From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: "Perry E. Metzger" <perry@piermont.com>
Cc: emacs-devel@gnu.org
Subject: Re: Non-ASCII chars in quail rules
Date: Wed, 03 Sep 2014 09:19:18 -0400 [thread overview]
Message-ID: <jwvzjegzvzp.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20140903074355.2a7cd6e2@jabberwock.cb.piermont.com> (Perry E. Metzger's message of "Wed, 3 Sep 2014 07:43:55 -0400")
> One note: CHARACTERP does a bit more than is actually needed here, it
> may be sufficient to say XINT (c) <= MAX_CHAR or to use the
> CHAR_VALID_P macro.
The only "more" it does, compared to XINT (c) <= MAX_CHAR is that it
checks >=0 which is redundant because we already compared with ' '.
> I am not sure what the intent here of the restriction was, but a more
> general solution for the entire line of the test might be
> CHAR_PRINTABLE_P depending on what that intent actually is. (I don't
> entirely understand the intent, so I can't say.)
The intent is to make sure that `c' is something we can insert in the
buffer (since that's what quail does). We could also remove this check
completely and allow using any event to trigger input-method-function,
but that does break the current quail.el, so it's clearly more "backward
incompatible".
Stefan
next prev parent reply other threads:[~2014-09-03 13:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-29 14:18 Non-ASCII chars in quail rules Perry E. Metzger
2014-08-30 1:13 ` Stefan Monnier
2014-08-30 22:48 ` Perry E. Metzger
2014-08-31 12:38 ` Stefan Monnier
2014-08-31 14:00 ` Perry E. Metzger
2014-08-31 21:29 ` Perry E. Metzger
2014-09-03 2:23 ` Stefan Monnier
2014-09-03 11:43 ` Perry E. Metzger
2014-09-03 13:19 ` Stefan Monnier [this message]
2014-09-03 21:59 ` Perry E. Metzger
2014-09-04 0:02 ` Stephen J. Turnbull
2014-09-04 13:57 ` Perry E. Metzger
2014-09-04 14:17 ` Stephen J. Turnbull
2014-09-04 15:20 ` Perry E. Metzger
2014-09-04 15:37 ` Eli Zaretskii
2014-09-04 22:52 ` Stephen J. Turnbull
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvzjegzvzp.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=perry@piermont.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).