unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: Using different default-directory and relative paths in VC, Was: Re: bug#21383
Date: Mon, 07 Sep 2015 18:33:56 -0400	[thread overview]
Message-ID: <jwvzj0xeua7.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <55EDF9BC.3000605@yandex.ru> (Dmitry Gutov's message of "Mon, 7 Sep 2015 23:55:24 +0300")

>>> Does vc-status get a relative file name as input?
>> Currently, I don't think so.  But that could be changed if needed.
> Hopefully not.
>>> b) how are you going to enforce it?.
>> By checking all callers?
> That's an odd thing to do for an API. What if diff-hl calls vc-state with an
> absolute path? Will it get a slap on the wrist?

Sorry, I didn't realize you were talking about vc-state.  No I guess
vc-state would have to keep working with absolute file names (tho it
could be extended to also accept relative file names).

> in question should work well enough. Although when a command is
> passed a list of files, determining their common parent will require
> more effort.

I'd expect that the caller should be able to easily arrange for each
file in the list to *already* be relative to default-directory, so
there's no need to look for the common parent.


        Stefan



  reply	other threads:[~2015-09-07 22:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAAW2-ZfFt-D9VX_xU1Sp2tCL_59LreL3wCen0-Snia7H8mmrpA@mail.gmail.com>
     [not found] ` <jwvpp24t6cq.fsf-monnier+emacsbugs@gnu.org>
     [not found]   ` <55E41499.5030501@yandex.ru>
     [not found]     ` <jwvio7ve4o4.fsf-monnier+emacsbugs@gnu.org>
     [not found]       ` <55E5094A.3010108@yandex.ru>
     [not found]         ` <jwvmvx6sso7.fsf-monnier+emacsbugs@gnu.org>
     [not found]           ` <55E59487.1050804@yandex.ru>
     [not found]             ` <jwvtwreqh6n.fsf-monnier+emacsbugs@gnu.org>
     [not found]               ` <55E5CA42.1080005@yandex.ru>
     [not found]                 ` <jwv1teiqdz2.fsf-monnier+emacsbugs@gnu.org>
     [not found]                   ` <55E5DF1A.9010902@yandex.ru>
     [not found]                     ` <jwv4mjdqyad.fsf-monnier+emacsbugs@gnu.org>
     [not found]                       ` <55E6D426.10105@yandex.ru>
     [not found]                         ` <jwvegifmr7x.fsf-monnier+emacsbugs@gnu.org>
     [not found]                           ` <55E89E83.6000501@yandex.ru>
     [not found]                             ` <jwvmvx3j5ir.fsf-monnier+emacsbugs@gnu.org>
     [not found]                               ` <55EA5CB0.9070007@yandex.ru>
     [not found]                                 ` <jwvlhckhpnc.fsf-monnier+emacsbugs@gnu.org>
     [not found]                                   ` <55EB50D7.2030103@yandex.ru>
     [not found]                                     ` <jwvzj0zmbkw.fsf-monnier+emacsbugs@gnu.org>
2015-09-07 20:55                                       ` Using different default-directory and relative paths in VC, Was: Re: bug#21383 Dmitry Gutov
2015-09-07 22:33                                         ` Stefan Monnier [this message]
2015-09-07 23:29                                           ` Dmitry Gutov
2015-09-07 23:34                                             ` Dmitry Gutov
2015-09-08  1:31                                             ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvzj0xeua7.fsf-monnier+emacsbugs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=dgutov@yandex.ru \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).