From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Subject: Re: Warning compiling obarray.el on master
Date: Sat, 18 Mar 2017 08:49:05 -0400 [thread overview]
Message-ID: <jwvzigin46i.fsf-monnier+gmane.emacs.devel@gnu.org> (raw)
In-Reply-To: 83inn8z3ax.fsf@gnu.org
> ELC ../lisp/obarray.elc
> In toplevel form:
> obarray.el:40:1:Warning: Lexical argument shadows the dynamic variable obarray
It's "harmless" and it's the result of having a global variable with
a short name like `obarray` which hence unavoidably collides with
local uses.
I see the rest of obarray.el uses the name `ob` for local variables
instead, so I guess using that in `obarray-copy` is the best fix in the
short term.
In the longer term, maybe we should rename `obarray` to something more
descriptive and less likely to collide with a local var.
Maybe `default-obarray` or `global-obarray` or
`global-identifier-obarray`?
Stefan
next prev parent reply other threads:[~2017-03-18 12:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-17 8:59 Warning compiling obarray.el on master Eli Zaretskii
2017-03-18 12:49 ` Stefan Monnier [this message]
2017-03-18 13:30 ` Eli Zaretskii
2017-03-18 13:47 ` Lars Ingebrigtsen
2017-03-18 14:00 ` Noam Postavsky
2017-03-18 14:05 ` Lars Ingebrigtsen
2017-03-18 16:32 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvzigin46i.fsf-monnier+gmane.emacs.devel@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).