unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Cc: Michael Mauger <michael@mauger.com>,
	Alex Harsanyi <alexharsanyi@gmail.com>,
	pierre.techoueyres@free.fr
Subject: Re: syntax based indentation for SQL files (ELPA package proposal)
Date: Sun, 06 Aug 2017 13:54:22 -0400	[thread overview]
Message-ID: <jwvzibc7fc5.fsf-monnier+gmane.emacs.devel@gnu.org> (raw)
In-Reply-To: CAH-ciFraqUFpCvwiQF=qFnc5_6N4yUXZbsxKJqXL+u+b1TnVVw@mail.gmail.com

> I'm not sure what are the next steps for this?

I think the main question is whether it can/should be included in
sql.el.  Maybe the best strategy is the following:

- add sqlindent.el more-or-less as-is into Emacs's `master` branch as
  lisp/progmodes/sqlindent.el
- change sql.el to use that indentation package by default.

Michael, what do you say?  Do you want to include sqlindent.el directly
into sql.el?

> I already have signed copyright assignment for GNU Emacs contributions
> in the past.  The package has another contributor, Pierre Téchoueyres,
> I'm not sure if he has signed the copyright assignment papers or not
> (I just sent him an email asking this).

Yes, he has already signed paperwork for Emacs.

> I think this should be a separate package, at least initially.  Based
> on feedback from Michael who maintains sql.el, there might be people
> who prefer the way sql-mode works now, as it has been like this for a
> long time.

I believe the default behavior should be to enable automatic
indentation.  We can provide some way for the user to disable it, of
course (actually, I think it would make sense to offer a generic minor
mode which provides "dumb" indentation in any major mode).


        Stefan




  reply	other threads:[~2017-08-06 17:54 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-06  2:42 syntax based indentation for SQL files (ELPA package proposal) Alex Harsanyi
2017-08-06  4:05 ` Stefan Monnier
2017-08-06  6:35   ` Steinar Bang
2017-08-06 13:30   ` Alex Harsanyi
2017-08-06 17:54     ` Stefan Monnier [this message]
     [not found]       ` <j3XyL-aaKw13ov6PDSlK6YTLNYM6WwKGtS-OW5wgKzI9C4QQ1lDjHvosCxVSOEbqEaQOThHg4DKnPLVJO9ogqg==@protonmail.com>
2017-08-14  9:51         ` Stefan Monnier
2017-08-14 20:47           ` John Wiegley
2018-09-11 10:09       ` simenheg
2018-09-11 12:16         ` Stefan Monnier
2018-09-16  1:11           ` Michael Mauger
2018-09-16 21:30             ` Stefan Monnier
2018-10-01 12:56               ` Michael Mauger
2018-10-01 18:24                 ` Stefan Monnier
2018-10-01 22:31                 ` Andy Moreton
2018-10-02 12:57                   ` Stefan Monnier
2018-10-02 13:48                     ` Andy Moreton
2018-10-02 14:24                       ` Van L
2018-10-02 16:07                       ` Stefan Monnier
2018-10-02 13:49                     ` Thomas Fitzsimmons

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvzibc7fc5.fsf-monnier+gmane.emacs.devel@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=alexharsanyi@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=michael@mauger.com \
    --cc=pierre.techoueyres@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).