Re: [Emacs-diffs] emacs-26 35e0305: Avoid turning on the global-minor-mode recursively

Re: [Emacs-diffs] emacs-26 35e0305: Avoid turning on the global-minor-mode recursively

[Stefan Monnier]

> +         (let ((buffers ,MODE-buffers))
> +           ;; Clear MODE-buffers to avoid scanning the same list of
> +           ;; buffers in recursive calls to MODE-enable-in-buffers.
> +           ;; Otherwise it could lead to infinite recursion.
> +           (setq ,MODE-buffers nil)
> +           (dolist (buf buffers)

Thanks.

BTW, in most other places where we need to "extract the content" of
a worklist like above, we do it with something like:

    (... (prog1 FOO (setq FOO nil)) ...)


-- Stefan

Re: [Emacs-diffs] emacs-26 35e0305: Avoid turning on the global-minor-mode recursively

[John Shahid]

Stefan Monnier <monnier@IRO.UMontreal.CA> writes:

>> +         (let ((buffers ,MODE-buffers))
>> +           ;; Clear MODE-buffers to avoid scanning the same list of
>> +           ;; buffers in recursive calls to MODE-enable-in-buffers.
>> +           ;; Otherwise it could lead to infinite recursion.
>> +           (setq ,MODE-buffers nil)
>> +           (dolist (buf buffers)
>
> Thanks.
>
> BTW, in most other places where we need to "extract the content" of
> a worklist like above, we do it with something like:
>
>     (... (prog1 FOO (setq FOO nil)) ...)
>
>
> -- Stefan

Should I submit a patch ?

Re: [Emacs-diffs] emacs-26 35e0305: Avoid turning on the global-minor-mode recursively

[Stefan Monnier]

>> BTW, in most other places where we need to "extract the content" of
>> a worklist like above, we do it with something like:
>>     (... (prog1 FOO (setq FOO nil)) ...)
> Should I submit a patch ?

Your call.  Maybe we could even introduce a `destructive-read` macro for
that ;-)


        Stefan