* Re: [elpa] master b6ac53b: * packages/math-symbol-lists/msl-build.el: Add copyright and license
[not found] ` <20190507123146.5DF3B20407@vcs0.savannah.gnu.org>
@ 2019-05-07 14:10 ` Vitalie Spinu
2019-05-07 15:13 ` Stefan Monnier
0 siblings, 1 reply; 2+ messages in thread
From: Vitalie Spinu @ 2019-05-07 14:10 UTC (permalink / raw)
To: emacs-devel; +Cc: Stefan Monnier
Thanks! That file contains just dirty manual hacks to parse the symbol lists
from various sources. It's not intended to be loaded or used by other libraries.
I think the packager might get confused and think of it as a multi-file
package. What would be the recommended way to put it off the load path? Just
store in a sub-dir?
Thanks,
Vitalie
>> On Tue, May 07 2019 08:31, Stefan Monnier wrote:
> branch: master
> commit b6ac53b667b8a057db0f31a6348ca373338b9561
> Author: Stefan Monnier <monnier@iro.umontreal.ca>
> Commit: Stefan Monnier <monnier@iro.umontreal.ca>
> * packages/math-symbol-lists/msl-build.el: Add copyright and license
> While I was there I also fixed the following:
> Use lexical-binding. Require cl-lib since it's used, and stop using `cl`.
> Fix namespace to always start with "msl-".
> Wrap toplevel operations into a `defun` since files in `load-path` may be
> loaded gratuitously by Emacs.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [elpa] master b6ac53b: * packages/math-symbol-lists/msl-build.el: Add copyright and license
2019-05-07 14:10 ` [elpa] master b6ac53b: * packages/math-symbol-lists/msl-build.el: Add copyright and license Vitalie Spinu
@ 2019-05-07 15:13 ` Stefan Monnier
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Monnier @ 2019-05-07 15:13 UTC (permalink / raw)
To: Vitalie Spinu; +Cc: emacs-devel
> Thanks! That file contains just dirty manual hacks to parse the symbol
> lists from various sources. It's not intended to be loaded or used by
> other libraries.
That's what I figured, yes.
But since it's in `load-path` Emacs might still load it unexpectedly.
This said, I found that placing such "random code" within a dummy
(defun ...) wrapper solves this problem in a trivial way without any
significant downside (I actually found it to be helpful because the
defun's name helps me describe what this is about and often enough
I later discover that I actually did want a defun for that anyway ;-)
> I think the packager might get confused and think of it as a multi-file
> package.
Indeed, it will.
> What would be the recommended way to put it off the load path?
> Just store in a sub-dir?
You could do that, or you could keep it out of the tarball via
`.elpaignore`, but based on what you just said, maybe you just want to
add:
;; Package-Type: simple
to the header of math-symbol-lists.el?
Stefan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-05-07 15:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20190507123145.27618.34624@vcs0.savannah.gnu.org>
[not found] ` <20190507123146.5DF3B20407@vcs0.savannah.gnu.org>
2019-05-07 14:10 ` [elpa] master b6ac53b: * packages/math-symbol-lists/msl-build.el: Add copyright and license Vitalie Spinu
2019-05-07 15:13 ` Stefan Monnier
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).