From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Towards a cleaner build Date: Wed, 12 Jun 2019 18:07:04 -0400 Message-ID: References: <83zhn6zkgf.fsf@gnu.org> <83a7eo9nsh.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="70584"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jun 13 00:08:24 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hbBPs-000ICo-JQ for ged-emacs-devel@m.gmane.org; Thu, 13 Jun 2019 00:08:24 +0200 Original-Received: from localhost ([::1]:35354 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hbBPp-0004HM-3U for ged-emacs-devel@m.gmane.org; Wed, 12 Jun 2019 18:08:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44310) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hbBOy-0004H3-Rn for emacs-devel@gnu.org; Wed, 12 Jun 2019 18:07:29 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hbBOv-0005Xx-48 for emacs-devel@gnu.org; Wed, 12 Jun 2019 18:07:26 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:62491) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hbBOr-0005Qw-By for emacs-devel@gnu.org; Wed, 12 Jun 2019 18:07:23 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id E6725100946 for ; Wed, 12 Jun 2019 18:07:07 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id B2D401007B5 for ; Wed, 12 Jun 2019 18:07:06 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1560377226; bh=kah68PZ7B/0EDthJlxi8ESQTJxrTDDaI0zfn7YLD870=; h=From:To:Subject:References:Date:In-Reply-To:From; b=di8GKA0Bz9AfYi0W+SnQDNNrYPjhSBP8UCuP+/RUKP/fia99qeMNNFOZ+XtPH3HPZ 1RuWrlGRiLv1SIustKYj7BMy8OhfTxuy3sFKZhKeIRMmVOPqha0fg7dNZ6ZEt9uGEc Tt/b5rX6wsDpEW00Kcv0g41E7fPLx7Q/fZH2Qr5CsrQZkfN2YWWCj8TJGitssaLQUo +OPZEVVIYA+IVZIvId9SRsaO28yOAbILV/lAtBoyjHdzE+adZh0ZUKBzzv2EqtullG yiI40qKQwTfWwlW7pBP7ZW8bF8G2S4mG7PB91z58u/94XWzEdZLI133GO6IouI71xK Kj0O1cV5MlM6Q== Original-Received: from alfajor (cm-84.215.66.78.getinternet.no [84.215.66.78]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 5013B120BBB for ; Wed, 12 Jun 2019 18:07:06 -0400 (EDT) Cancel-Lock: sha1:J6k98NkPJJ/fVNTlrRJcxVDXe7I= In-Reply-To: (Lars Ingebrigtsen's message of "Wed, 12 Jun 2019 18:37:15 +0200") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 132.204.25.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:237464 Archived-At: > OK, in the toplevel lisp directory there's now only four warnings. > > In toplevel form: > isearchb.el:80:1:Warning: Package iswitchb is obsolete! > > But as far as I can tell, the entire point of the isearchb package is to > interact with isiwtchb, so should this also be obsolete? It is currently built on top of iswitchb and offers a way to "fallback" to iswitchb, but it could/should be rewritten not to rely on iswitchb. > This one I'm not sure what the status is with: It's an obsolete > variable, but it seems unsure how it should be replaced here, Right, it should be replaced by obsoleting the `pcomplete` command (not the package). > In pcomplete/tar: > pcmpl-gnu.el:162:47:Warning: `pcomplete-suffix-list' is an obsolete variable > (as of 24.1). > > I'm not sure whether suppressing this warning is the right thing, > either... Agreed. > And the final two Eli was pondering what to do with, so I'll just leave > them as warnings for further pondering. > > In gui-get-selection: > select.el:316:23:Warning: `string-to-multibyte' is an obsolete function (as of > 26.1); use `decode-coding-string'. I think, just as for string-to-unibyte, we likely should un-obsolete string-to-multibyte. Arguably, here we could just return the unibyte string without passing it through string-to-multibyte, tho. > In xselect--encode-string: > select.el:482:24:Warning: `string-make-unibyte' is an obsolete function (as of > 26.1); use `encode-coding-string'. This one should be string-to-unibyte. Stefan