From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Towards a cleaner build: pcomplete Date: Mon, 17 Jun 2019 09:23:58 -0400 Message-ID: References: <83zhn6zkgf.fsf@gnu.org> <83a7eo9nsh.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="127938"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jun 17 15:24:45 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hcrcr-000X7m-Cx for ged-emacs-devel@m.gmane.org; Mon, 17 Jun 2019 15:24:45 +0200 Original-Received: from localhost ([::1]:47492 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hcrcq-00049h-EO for ged-emacs-devel@m.gmane.org; Mon, 17 Jun 2019 09:24:44 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55417) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hcrcB-00049a-Ct for emacs-devel@gnu.org; Mon, 17 Jun 2019 09:24:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hcrcA-0006f5-Dp for emacs-devel@gnu.org; Mon, 17 Jun 2019 09:24:03 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:63334) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hcrcA-0006e2-6c for emacs-devel@gnu.org; Mon, 17 Jun 2019 09:24:02 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 5C75B443A1B; Mon, 17 Jun 2019 09:24:01 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 38069443A1F; Mon, 17 Jun 2019 09:24:00 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1560777840; bh=lUJLYZAP4VN4Y+/JKSR5Pps1Xh7ox9MApJy07Yn7VaA=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=jQur6BuEHj8f9LOd4LlaiF055317u4YT110hLoAvncEXWK82GeLtOjYRh5q7N2Gg+ rhgh9RLvOC43NYTE7Q/naq96V7aUxkUcBGZj8YQk0xaRSkLT1Iohyr1DiqJKmCa0cI hN5ZPEm6CZu7ZyVjMqp2se9kmotzRzcQCaVMHIFXnYTlDit0Vblp7DUg9gGGBXDKtJ hCb1TQFn3wKcHj9tCkTUuZMRHEnkZphVizhot7ucupuFlv0Dck6hWw7YzW2BPJWR97 o9rML1+2rFSBxGL+hyhLtfJrRzSaP+ozR1WObTKDKbHo1avU8UOjslNKWdBOWxRrzT uNHjYRLKgRTmw== Original-Received: from alfajor (unknown [157.52.10.58]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 0C3C7120D41; Mon, 17 Jun 2019 09:23:59 -0400 (EDT) In-Reply-To: (Lars Ingebrigtsen's message of "Mon, 17 Jun 2019 14:08:49 +0200") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 132.204.25.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:237782 Archived-At: >>> In pcomplete/tar: >>> pcmpl-gnu.el:162:47:Warning: `pcomplete-suffix-list' is an obsolete variable >>> (as of 24.1). [...] > Actually, looking at the code further, I don't quite understand this one > at all... These functions are the ones that are called when you hit TAB > in M-x shell buffers (and the like)? So "tar --v" will complete > over the completions like "--verbose"? Right. > And, as we can see, that function is not called from pcomplete/tar, so > the binding of pcomplete-insert-entry in pcomplete/tar doesn't seem like > it could possibly affect anything? I think you're right: this binding is likely the result of a misunderstanding (contrary to the setting of pcomplete-suffix-list in lisp/eshell/em-cmpl.el). Stefan