unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: "Clément Pit-Claudel" <cpitclaudel@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: Shouldn't records be sequences?
Date: Sun, 12 Apr 2020 13:23:10 -0400	[thread overview]
Message-ID: <jwvzhbgpqrm.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <0e837a01-0d38-27e2-179c-e6aca1872248@gmail.com> ("Clément Pit-Claudel"'s message of "Sun, 12 Apr 2020 12:46:07 -0400")

>> but that's only motivated by the need for backward compatibility with
>> code which used to expect `cl-defstruct` to use vectors instead of
>> records.
> Isn't performance part of it too?

It could be relevant, tho I can't remember it being a factor in practice.

> A recent example: I have a list of records that I display to users,
> using a custom sort order (a list of record fields).  It's convenient
> to be able to go from list of fields to list of array offsets once,
> and then use those offsets in the comparison function (this is similar
> to what I'd do with C structs).

Not sure how that relates to treating them as sequences.
We do want some way to work at the lower level (i.e. access the N'th
field), which is currently done with `aref` but could be done by
a `record-ref` instead.


        Stefan


PS: The clean equivalent in Elisp would be to use a list of
field-accessors instead of a list of fields.  This also saves you from
converting to a list of array offsets.  But (funcall accessor x) is
probably significantly slower than (aref x offset), indeed.  OTOH I can
imagine an implementation of Elisp where the cost is comparable
(because the `funcall` is cheap enough).






  reply	other threads:[~2020-04-12 17:23 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-12  9:35 Shouldn't records be sequences? Štěpán Němec
2020-04-12 12:03 ` Štěpán Němec
2020-04-12 16:30 ` Stefan Monnier
2020-04-12 16:46   ` Clément Pit-Claudel
2020-04-12 17:23     ` Stefan Monnier [this message]
2020-04-12 18:49       ` Clément Pit-Claudel
2020-04-12 17:02   ` Štěpán Němec
2020-04-12 19:14     ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvzhbgpqrm.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=cpitclaudel@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).