From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Remove obsolete fast-lock and lazy-lock libraries Date: Fri, 07 Aug 2020 22:19:32 -0400 Message-ID: References: <20200515175844.18941.61355@vcs0.savannah.gnu.org> <20200515175845.997EC20999@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16337"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Emacs developers To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Aug 08 04:20:19 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k4ET5-0004BL-E8 for ged-emacs-devel@m.gmane-mx.org; Sat, 08 Aug 2020 04:20:19 +0200 Original-Received: from localhost ([::1]:33144 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k4ET4-0004wC-1C for ged-emacs-devel@m.gmane-mx.org; Fri, 07 Aug 2020 22:20:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33428) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k4ESQ-0004U8-F4 for emacs-devel@gnu.org; Fri, 07 Aug 2020 22:19:38 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:21733) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k4ESO-0006pT-Bf for emacs-devel@gnu.org; Fri, 07 Aug 2020 22:19:37 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id B42B4100F88; Fri, 7 Aug 2020 22:19:34 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 04739100ACD; Fri, 7 Aug 2020 22:19:33 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1596853173; bh=GQKZEjBcaKGxXr0fhHcQrZtPX4WhK6OyDPNp2Bswfgw=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=ShM2Lce3N9qnsu4h/uiLB8tLdMG2Cp2841854rljyLC5X3JmY2XiCwSnwGIKKEYiW yVuTJ8C18DWrdJVT9oLVZE6DLzG6s6c0mlGvHgN2ViurL/SRJgOLw6avJDmsX+jWnO dHknBugrEZKjYVMBi1g1IKSsT394FVVzYZTw424hHgDFoLKn6fShl5e+9awFCYpIHt LSNHWJE1VeCRFjXk71e0/+u3bhqkkTqduxPlpm6mD0e7QQkLpa/a/RqNwMB7qTXVO3 ckFItMqPGsDnIhONonIbaf3jGqFZ8UmTp9X+bkHo2I6BPzt7MoZZZsIeA6wt3WHJf8 g3TYdB3ouL5hQ== Original-Received: from milanesa (unknown [45.72.246.108]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id CB0501203BC; Fri, 7 Aug 2020 22:19:32 -0400 (EDT) In-Reply-To: (Stefan Kangas's message of "Fri, 7 Aug 2020 17:42:33 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/07 22:19:34 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:253509 Archived-At: >> There are also these two libraries: >> ./lisp/obsolete/fast-lock.el9:;; Obsolete-since: 22.1 >> ./lisp/obsolete/lazy-lock.el9:;; Obsolete-since: 22.1 > I have attached a patch to remove them below. LGTM. > ;; to avoid compilation gripes > (defun ps-print-ensure-fontified (start end) > (cond ((and (boundp 'jit-lock-mode) (symbol-value 'jit-lock-mode)) > - (jit-lock-fontify-now start end)) > - ((and (boundp 'lazy-lock-mode) (symbol-value 'lazy-lock-mode)) > - (lazy-lock-fontify-region start end)))) > + (jit-lock-fontify-now start end)))) I think this can be replaced by `font-lock-ensure`, but it probably requires additional tests to be sure, so maybe keep the code as is and just add a FIXME. Stefan