From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 12409c9: New transient mode 'repeat-mode' to allow shorter key sequences (bug#46515) Date: Tue, 23 Feb 2021 17:08:35 -0500 Message-ID: References: <20210217180506.28704.14280@vcs0.savannah.gnu.org> <20210217180507.C061220DFB@vcs0.savannah.gnu.org> <87lfbln1w8.fsf@mail.linkov.net> <87h7m9co2d.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33154"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Feb 23 23:09:20 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lEfrr-0008Wn-Av for ged-emacs-devel@m.gmane-mx.org; Tue, 23 Feb 2021 23:09:19 +0100 Original-Received: from localhost ([::1]:52272 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lEfrq-0001xA-CV for ged-emacs-devel@m.gmane-mx.org; Tue, 23 Feb 2021 17:09:18 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39362) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lEfrG-0001H9-7W for emacs-devel@gnu.org; Tue, 23 Feb 2021 17:08:42 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:10672) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lEfrD-000716-Uf for emacs-devel@gnu.org; Tue, 23 Feb 2021 17:08:41 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id D1A7B80194; Tue, 23 Feb 2021 17:08:38 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 61B7C8090A; Tue, 23 Feb 2021 17:08:37 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1614118117; bh=eMjvK7S+2wTutp7M9sGA2bgsKXfpKylcsism7r2cv0U=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=a1uv03vPv+ApZnTEUkJCI7PI6YIGl77YI2iEIEoBvMBpEOwyXfk2AFNJwLlPu1mmy xGAs6seEhTI2BAJIYSqr+wZCU7cElOOHuRxV0+v8FpOG4eFQMHV5rJ5AwmVC/uNdwl 3WOs3nhVsT5Fpb+SkeIDhmTxDTkIvH2f7ZIcKsai4j68LcuLocOgCx56YQEZVc4Gln nBiNQ6+YaDdlgIfVTyMr3BQ+luElgar5731tI5umypjur04CGYnAbo8K5tfOiaTBF/ T74xQ3UiSPm0KevzaPXKaFZaFXmXfy0pGhOcgy8Bb6c6j4YNpO7Gi4lgmZnxwUoJKL /AxWQS50vmF+w== Original-Received: from alfajor (unknown [216.154.41.47]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 0CD8C120351; Tue, 23 Feb 2021 17:08:36 -0500 (EST) In-Reply-To: <87h7m9co2d.fsf@mail.linkov.net> (Juri Linkov's message of "Thu, 18 Feb 2021 19:29:10 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:265556 Archived-At: >>>>> +(defvar next-error-repeat-map >>>>> + (let ((map (make-sparse-keymap))) >>>>> + (define-key map "n" 'next-error) >>>>> + (define-key map "\M-n" 'next-error) >>>>> + (define-key map "p" 'previous-error) >>>>> + (define-key map "\M-p" 'previous-error) >>>>> + map) >>>>> + "Keymap to repeat next-error key sequences. Used in `repeat-mode'.") >>>>> +(put 'next-error 'repeat-map 'next-error-repeat-map) >>>>> +(put 'previous-error 'repeat-map 'next-error-repeat-map) >>>> >>>> Could we avoid this duplication between the map and the >>>> `repeat-map` property? >> >> There is in the above code snippet: the `put` statements are redundant >> since the same info is fundamentally already available from >> `next-error-repeat-map`. > > Now I see where is duplication. But currently I have no idea > in what keymaps post-command-hook should look for keybindings. I don't see the problem: since your code installs the keymap, it can also arrange to stash the info of which keymap to look up. Stefan