From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New package: vertico Date: Sat, 10 Apr 2021 11:19:03 -0400 Message-ID: References: <87im4vglwv.fsf@gnu.org> <87sg3y7g7x.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40682"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Daniel Mendler Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Apr 10 17:19:51 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lVFOp-000AUj-2O for ged-emacs-devel@m.gmane-mx.org; Sat, 10 Apr 2021 17:19:51 +0200 Original-Received: from localhost ([::1]:35886 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lVFOo-0006yH-3C for ged-emacs-devel@m.gmane-mx.org; Sat, 10 Apr 2021 11:19:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47062) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lVFOG-0006Xq-0l for emacs-devel@gnu.org; Sat, 10 Apr 2021 11:19:16 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:44782) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lVFOD-0001FU-BE for emacs-devel@gnu.org; Sat, 10 Apr 2021 11:19:14 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id EF05D440B88; Sat, 10 Apr 2021 11:19:11 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 6C90F440873; Sat, 10 Apr 2021 11:19:10 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1618067950; bh=c1kooUjEiOdGy878Im02YdE0r74yJAGWUJPeG9ZdvIU=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=H2Ogo4ydOYQQsIhu5Gu2mIgm3gHMS0uwvrEYXmXn8C6xu1jcwnh0QP6MloI2c29PJ s/SEiCAGFfK8KaIvIx/gLlEziAwgVVxA228PpbaD6Hu43kn5gkLS3vvZSxPxEllSsE OrSF1HPIo+S2ErcuT3NbPdJPsl5pVvWhvRHcdPtEQ3qkT5IriSDDPTxUVBNplgSYhG 14gA9HRpD8qgDFymBia5418x2P0VQe2eMoG+yf1IGuTiuaNxhz0EM/NtSOA2iq+sB2 Z3mkL8xpaCEP4pRkbaTx8IFVKKeyTXzV0rqiZrejmdg8rj76SeQAWX95BjssVdms93 um0i5t90TLTaw== Original-Received: from alfajor (104-222-126-84.cpe.teksavvy.com [104.222.126.84]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 44A8D1201E6; Sat, 10 Apr 2021 11:19:10 -0400 (EDT) In-Reply-To: (Daniel Mendler's message of "Sat, 10 Apr 2021 16:07:56 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:267830 Archived-At: >> Maybe a way to handle it "right" is for vertico to register an >> `after-change-function` so as to detect also when the buffer's content is >> modified outside of the normal commands (i.e. from a timer or process >> filter). It'd probably be a bit messy, tho: it wouldn't want to refresh >> the completion list right away, but there's no "obvious" later hook to >> use (like `post-command-hook`) so it would need to detect when there's >> not going to be a subsequent post-command-hook (i.e. when we're in >> a timer or similar) and then probably fire its own timer to update the >> completion list when the current processing is done. >> Or maybe it should use `after-change-function` to detect changes and >> `pre-redisplay-functions` to update the list of completion. > > Yes, there are other hooks that could be used. I like to keep it simple as > is and introduce nothing messy. I follow the design taken by Icomplete which > works well. FWIW, I'm not convinced either that the extra complexity of what I propose is worth the trouble. Stefan