From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Time to merge scratch/correct-warning-pos into master, perhaps? Date: Sat, 15 Jan 2022 17:57:08 -0500 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2875"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jan 15 23:58:18 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n8s01-0000V7-UL for ged-emacs-devel@m.gmane-mx.org; Sat, 15 Jan 2022 23:58:18 +0100 Original-Received: from localhost ([::1]:54018 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n8s01-0003K6-0b for ged-emacs-devel@m.gmane-mx.org; Sat, 15 Jan 2022 17:58:17 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:50808) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n8rz1-0002S9-G4 for emacs-devel@gnu.org; Sat, 15 Jan 2022 17:57:15 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:37949) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n8ryz-00022l-9b for emacs-devel@gnu.org; Sat, 15 Jan 2022 17:57:14 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 20C38442458; Sat, 15 Jan 2022 17:57:12 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id C8E27442457; Sat, 15 Jan 2022 17:57:10 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1642287430; bh=dRN4f0aGHVggPWpd1wc5iEz9SRQZ5hOAgQaHi6XnYbY=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=jl/QEfUW8G0Zu2P/pztLx1UByW8iUNDMfy/GXYB72mtfgmOBnI7r3HTEXZqpm6+0R xfIUVeVM/cf7FEAOizvWBX8mgaXKNujOxmgizSHzMqERBlwVQXEuPqBoGhERFhkl2v J8UZ6SUELQ8nl3srkDG1s3YMwFN+pJ0PwDAO9SKZUsONfsDHDamieuJtOhSjnaRquT +FGoOHL4/sIZ1vk5DhegPRXGh7rJJKCoNsT3LIjbEquEC+RCgXfw+X0vSZvsS8pyQh KnadLCQtgUy1FoE2KfIMiS1RdAYNf8j1vVPQgui3D3IWu/ZEW90kqIe+0Jt18AtFa/ Uja9sMh43eqVQ== Original-Received: from pastel (unknown [216.154.30.173]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 39824120445; Sat, 15 Jan 2022 17:57:10 -0500 (EST) In-Reply-To: (Alan Mackenzie's message of "Sat, 15 Jan 2022 18:15:17 +0000") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:284793 Archived-At: > In these benchmarks, I used the following function: > > (defun time-scroll-b (&optional arg) > (condition-case nil > (while t > (if arg (scroll-down) (scroll-up)) > (sit-for 0)) > (error nil))) Any chance you could add this benchmark to `elisp-benchmarks`? Has someone tried other benchmarks than this one? Could you say something about the impact of this patch outside of the obvious things in lread.c and bytecomp.el (other than performance), both in terms of what code is changed and what potential changes one might expect to see (and could affect for example external packages) in corner cases? Stefan