From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 2c8b09b06e7: Fix crash on Windows 9X Date: Mon, 05 Dec 2022 22:59:27 -0500 Message-ID: References: <167029029523.21453.12133435240921985505@vcs2.savannah.gnu.org> <20221206013135.E2E2DC004BE@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15922"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Po Lu To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Dec 06 05:00:23 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p2P82-0003wx-Qs for ged-emacs-devel@m.gmane-mx.org; Tue, 06 Dec 2022 05:00:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p2P7F-0000eq-BY; Mon, 05 Dec 2022 22:59:33 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p2P7D-0000ec-Ud for emacs-devel@gnu.org; Mon, 05 Dec 2022 22:59:31 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p2P7C-0003kM-Ib for emacs-devel@gnu.org; Mon, 05 Dec 2022 22:59:31 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 63AB1442746; Mon, 5 Dec 2022 22:59:29 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 2307A441DB8; Mon, 5 Dec 2022 22:59:28 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1670299168; bh=YhU9PQXU+pUXWoWi+f2fBs4LsQtSViSTgytHByB2SFo=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=oTnyQtzU6Ni/6CpmL16LIRGOzP2ksobDXQ6ldK6zqX7AUet4f/Ksin03tu2jW+kPH VBSyoGHiooY7oh4+zFiIsUtBzZrG198OK+gzl+ba5JRHxQj0C4PJ667cMclZdas5MD egI5uU/CHY15xnusvkTXZyngiB8uL6mKXZL0vJADt28DVUEzNmbdHDIktIEo+0qZWu CvU+zxtHmyBQla5w+S2Rax373O0CE35Fcek1GlLiUgSRjIcnXDX6iztMI4MIthsyj0 bNKTN0HadhimkEfalO4ucKVurKA4dM28U0NoTNgjIloJPzJ6pO9mHcmPdQ1HjZCYRL WNNfmcxQg79ig== Original-Received: from pastel (unknown [45.72.193.52]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 008DB12253B; Mon, 5 Dec 2022 22:59:27 -0500 (EST) In-Reply-To: <20221206013135.E2E2DC004BE@vcs2.savannah.gnu.org> (Po Lu via Mailing list for Emacs changes's message of "Mon, 5 Dec 2022 20:31:35 -0500 (EST)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:300952 Archived-At: > --- a/src/emacs.c > +++ b/src/emacs.c > @@ -1924,6 +1924,12 @@ Using an Emacs configured with --with-x-toolkit=lucid does not have this problem > Vcoding_system_hash_table. */ > syms_of_coding (); /* This should be after syms_of_fileio. */ > init_frame_once (); /* Before init_window_once. */ > + /* init_window_once calls make_initial_frame, which calls > + Fcurrent_time and bset_display_time, both of which allocate > + bignums. Without the following call to init_bignums, crashes > + happen on Windows 9X after dumping when GC tries to free a > + pointer allocated on the system heap. */ > + init_bignum (); > init_window_once (); /* Init the window system. */ > #ifdef HAVE_WINDOW_SYSTEM > init_fringe_once (); /* Swap bitmaps if necessary. */ I feel like I'm missing something: this adds a call to `init_bignum` whereas I expected the patch to *move* the call. Was this call simply missing? Stefan