From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Adding the `prescient` packages to NonGNU ELPA? Date: Mon, 19 Dec 2022 22:10:20 -0500 Message-ID: References: <16193c73-ab80-04c9-558f-d5e6142f38f3@protonmail.com> <87pmcj2lsg.fsf@posteo.net> <877cyq5qym.fsf@posteo.net> <87pmcivwrq.fsf@posteo.net> <87iliavw08.fsf@posteo.net> <807a3f55-e76a-583f-381a-e15adb270c46@protonmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20787"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Philip Kaludercic , North Year , Visuwesh , emacs-devel@gnu.org To: Okamsn Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Dec 20 04:11:11 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p7T26-0005DV-KF for ged-emacs-devel@m.gmane-mx.org; Tue, 20 Dec 2022 04:11:10 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p7T1S-00065U-12; Mon, 19 Dec 2022 22:10:30 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7T1Q-00064c-PH for emacs-devel@gnu.org; Mon, 19 Dec 2022 22:10:28 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7T1O-0008IR-QS for emacs-devel@gnu.org; Mon, 19 Dec 2022 22:10:28 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 770CC8056A; Mon, 19 Dec 2022 22:10:24 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id EC5EF80068; Mon, 19 Dec 2022 22:10:22 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1671505823; bh=oGe8x1Q18W8HE0uKwQnTnqq+K8bpE6JO/WykgNzRrc4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=pdnDjvwqMj7Fw7nDaF93O219KVn0DkqzRqL2cttsILZZlTkjtawCCuzBPvfvfKhOG wEWiTtUFI619d2HxbfO2BSqyO/TQGRjE/59fcoDWwJBrr6GdZ3gsSL8tHUujiaxem+ srQnxgbCOwY3SJwFNJ7RD44EA6DW30JBmGVhOwXu01WoHSYJLI977wdqFLkH+tBL7J vUrkbHIvPPUzR9BRxydXQOG0jwFP0y7/c0FEeRQ12Rn6iw7unOi1hgwTyMFxfoIZSC 4BkMhKDX0bVUOc1Ol6fDnq7owZ4WRVA+YO9JL+npWTXDzAI0mrExI7ADZkwzh/yqc/ KETbVrnRzq/SQ== Original-Received: from pastel (unknown [45.72.200.228]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 973F7120D4A; Mon, 19 Dec 2022 22:10:22 -0500 (EST) In-Reply-To: <807a3f55-e76a-583f-381a-e15adb270c46@protonmail.com> (okamsn@protonmail.com's message of "Tue, 20 Dec 2022 01:32:37 +0000") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:301676 Archived-At: > Would you please explain why one would want to use `add-function` > instead of directly setting `corfu-sort-function`, since setting the > variable is the intended use? Do you think that storing the old value is > insufficient? Two main reasons: - It's simpler (less code). - It has a chance of working correctly if some other package also comes and installs its own function there. > Also, you suggest using `message` to warn that `corfu` isn't found. > Would use of the function `user-error` be incorrect for this? Either way seems fine. Stefan