From: Stefan Monnier <monnier@iro.umontreal.ca>
To: "João Távora" <joaotavora@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>,
dalal.chinmay.0101@gmail.com, emacs-devel@gnu.org,
dimitri@belopopsky.com, luangruo@yahoo.com
Subject: Re: Eglot "inlay hints" landed
Date: Thu, 23 Feb 2023 14:27:57 -0500 [thread overview]
Message-ID: <jwvzg94dwc3.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <CALDnm51POo+Fs2P8ZD_9T4AAMWb75hE44CS0JrXBb3YTcsqV9A@mail.gmail.com> ("João Távora"'s message of "Thu, 23 Feb 2023 17:46:08 +0000")
> I'd love to switch over to the jit-lock implementation as it has
> potential to be much neater. But I can't seem to get it to not
> over-request stuff. I attach the patch I've been trying, and it's
> clearly got some thinkos when you test it. It doesn't help that
> `window-start` and `window-end` aren't -- apparently -- reliable
> when called from a jit-lock function.
Sorry, I have not followed the discussion, so I don't know what are
"inlay hints" nor how to test them. What problem do you see what you
try your code?
> +(defvar-local eglot--inlay-hints-outstanding (cons nil nil)
> + "Largest (BEG . END) window subregion not yet updated for inlay hints.")
> +
> +(defun eglot--update-hints (from to)
> + "Jit-lock function for Eglot inlay hints."
> + (cl-symbol-macrolet ((x eglot--inlay-hints-outstanding))
> + (setq x (cons (min from (or (car x) most-positive-fixnum))
> + (max to (or (cdr x) 0))))
> + (let ((w (get-buffer-window)))
> + (trace-values "window: " w)
> + (trace-values "window-region: " (cons (window-start w) (window-end w)))
> + (trace-values "outstanding: " eglot--inlay-hints-outstanding)
> + ; FIXME: this is NOT the correct condition to decide when to
> + ; request stuff from the server.
> + (when (or (< (car x) (window-start w)) (> (cdr x) (window-end w)))
> + (unwind-protect
> + (eglot--update-hints-1 (car x) (cdr x))
> + (setq x (cons nil nil)))))))
Why do you compare to `window-start/end`?
As you say, they're not reliably available during jit-lock, and that's
for fundamental reasons: jit-lock effects can change `window-start/end`.
But I can't see a good reason why you'd need to do such comparison:
the fact that jit-lock calls you is supposed to say "we need this for
redisplay", so you shouldn't need to double-check against window bounds.
Unless maybe you have `jit-lock-stealth-time` set to a non-nil value, in
which case indeed jit-lock will be called even on non-displayed areas of
the buffer, but it's arguably what the user (you in this case) asked for.
IOW, you should be able to skip `eglot--update-hints` altogether and use
`eglot--update-hints-1` directly (modulo catching errors and such maybe).
Stefan
next prev parent reply other threads:[~2023-02-23 19:27 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <ypi9cz6ahi5n.fsf@gmail.com>
[not found] ` <83edqqaf8c.fsf@gnu.org>
[not found] ` <2B284D77-97DF-4B3E-89FB-13F0CA93D240@gmail.com>
[not found] ` <CALDnm53otfeDQGr0dWWUhxGLTSuiWTstLXJz1HXQgWLiAgsk=A@mail.gmail.com>
[not found] ` <CA+46MXbbW60t=JccgKGX39jTkOu+i=GZhzSQsfnqBUPb-mnJWg@mail.gmail.com>
2023-02-22 19:42 ` Eglot "inlay hints" landed João Távora
2023-02-23 1:45 ` [SPAM UNSURE] " Stephen Leake
2023-02-23 5:29 ` Chinmay Dalal
2023-02-23 6:31 ` Eli Zaretskii
2023-02-23 9:55 ` Chinmay Dalal
2023-02-23 10:03 ` João Távora
2023-02-23 10:55 ` Dimitri Belopopsky
2023-02-23 11:07 ` João Távora
2023-02-23 12:03 ` João Távora
2023-02-23 13:25 ` Dimitri Belopopsky
2023-02-23 11:05 ` Eli Zaretskii
2023-02-23 11:23 ` João Távora
2023-02-23 12:36 ` Eli Zaretskii
2023-02-23 12:57 ` João Távora
2023-02-23 14:48 ` Eli Zaretskii
2023-02-23 16:09 ` João Távora
2023-02-23 17:17 ` Eli Zaretskii
2023-02-23 17:46 ` João Távora
2023-02-23 18:01 ` Eli Zaretskii
2023-02-23 19:26 ` João Távora
2023-02-23 19:54 ` Eli Zaretskii
2023-02-23 20:03 ` João Távora
2023-02-23 19:27 ` Stefan Monnier [this message]
2023-02-23 19:39 ` João Távora
2023-02-23 19:53 ` Stefan Monnier
2023-02-23 20:09 ` João Távora
2023-02-23 22:19 ` Stefan Monnier
2023-02-23 23:59 ` João Távora
2023-02-24 1:08 ` Stefan Monnier
2023-02-24 2:28 ` João Távora
2023-02-24 7:35 ` Eli Zaretskii
2023-02-24 10:42 ` João Távora
2023-02-24 11:33 ` Eli Zaretskii
2023-02-24 12:26 ` João Távora
2023-02-23 10:17 ` Tassilo Horn
2023-02-23 12:55 ` Chinmay Dalal
2023-02-23 19:50 ` Nikola Pajkovsky
2023-02-23 21:35 ` João Távora
2023-02-23 21:45 ` Nikola Pajkovsky
2023-02-24 4:20 ` Chinmay Dalal
2023-02-24 5:04 ` Chinmay Dalal
2023-02-24 9:59 ` João Távora
2023-02-24 11:03 ` Nikola Pajkovsky
2023-02-27 22:50 ` Johann Klähn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvzg94dwc3.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=dalal.chinmay.0101@gmail.com \
--cc=dimitri@belopopsky.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=joaotavora@gmail.com \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).