unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Po Lu <luangruo@yahoo.com>,  emacs-devel@gnu.org
Subject: Re: Bug or feature?
Date: Sat, 15 Jun 2024 11:42:50 -0400	[thread overview]
Message-ID: <jwvzfrmgr74.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <86v82soj02.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 01 Jun 2024 17:06:05 +0300")

>> There is an elaborate segment of code in reset_buffer_local_variables
>> for, among other actions, eliminating outdated value cells from
>> buffer-local symbols that is not run when the shortcut is taken of
>> clearing local_var_alist_ in the case where PERMANENT_TOO is set, which
>> I suspect results in variable watchers being ignored and outdated symbol
>> values persisting.  Is there a specific reason for this discrepancy, or
>> is it just an oversight?
> Stefan, any comments?

Yes, it was an oversight in my commit 3ddff0803415.

This code also has another related problem because the var watchers can
change `local_var_alist`.  And I can't see in the code what prevents us
from running the watcher twice for those vars with `Qpermanent_local_hook`.
Oh, and calling `swap_in_global_binding` doesn't sound quite right
if we don't kill the var (because of `Qpermanent_local_hook`).


        Stefan




      parent reply	other threads:[~2024-06-15 15:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87zfsn7evr.fsf.ref@yahoo.com>
2024-05-18  7:34 ` Bug or feature? Po Lu
2024-06-01 14:06   ` Eli Zaretskii
2024-06-15  7:55     ` Eli Zaretskii
2024-06-15  9:52       ` John ff
2024-06-15 15:42     ` Stefan Monnier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvzfrmgr74.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=luangruo@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).