From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: trusted-content seems to have effect only with sources specified. Date: Sat, 28 Dec 2024 09:48:09 -0500 Message-ID: References: <861pxty189.fsf@gnu.org> <86ed1suoyt.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14742"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Michelangelo Rodriguez , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Dec 28 15:48:45 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tRY7R-0003eu-08 for ged-emacs-devel@m.gmane-mx.org; Sat, 28 Dec 2024 15:48:45 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tRY73-0004wb-SJ; Sat, 28 Dec 2024 09:48:21 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tRY70-0004wN-Oq for emacs-devel@gnu.org; Sat, 28 Dec 2024 09:48:19 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tRY6w-0003iF-66; Sat, 28 Dec 2024 09:48:16 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id E0B0D8089D; Sat, 28 Dec 2024 09:48:10 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1735397290; bh=UaogrwfsKwwbgQMt+Xaz2b8I5U+dmZxZ1AJH4liw5tc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=W8WaKpUhqea0sJPHxkv0C9PZGnsTPu4OgSYoBcB7ih0lqzxR2nJgrClU62KEtwPzg 0TJZMK+f55ARJfj/+DZgYMgeqk/xL38TU136WNtL/oG3xQLsn/cIF8VdqUEFTfs+H6 rbJ0YKkDlghF3nMBcU2l1KRUM05pD7A+JAl2B5z8xeuE+/b6KBHfwXy7gtolI2iycl mY5QBrzl6P6nTZbkf9SomWHX3fR2K9vhZqb5SZN84F9hSV3MZoBP+iqp+I722gX8rz ZzWMeq1a8TOvUKpWVCVSY4GHWwlLrR+Q29R10po3Yog3Mlo+K/37s/M6coeaNYgJdH EIyQcHRUfO+4A== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 0E3AA806EF; Sat, 28 Dec 2024 09:48:10 -0500 (EST) Original-Received: from pastel (104-195-225-43.cpe.teksavvy.com [104.195.225.43]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id CE08B120550; Sat, 28 Dec 2024 09:48:09 -0500 (EST) In-Reply-To: <86ed1suoyt.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 28 Dec 2024 11:38:34 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:327273 Archived-At: >> I discovered the issue, i think. >> Incidentally the packages i refer in `trusted-content' are installed via >> `package-vc-install-from-checkout', that generates a symlink in the >> directory in which we install our packages. >> If i specify in `trusted-content' the symlink, it generates the error. >> So we should specify only real paths. > > I think it's a feature: It was done on purpose, yes: (defun trusted-content-p () "Return non-nil if we trust the contents of the current buffer. Here, \"trust\" means that we are willing to run code found inside of it. See also `trusted-content'." ;; We compare with `buffer-file-truename' i.s.o `buffer-file-name' ;; to try and avoid marking as trusted a file that's merely accessed ;; via a symlink that happens to be inside a trusted dir. > it will catch the case of a malicious symlink > that redirects your trusted file/directory to a different place. In his case, the symlink presumably can't be malicious since it's inside a trusted directory. But I didn't want this trust to be transitive: just because the symlink is non-malicious doesn't mean the target can't contain things we can't control. You may setup a perfectly valid symlink to an area where you download random crap. Stefan