From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Index header in diff-mode Date: Fri, 09 Dec 2005 09:38:40 -0500 Message-ID: References: <873bl4f9wd.fsf@jurta.org> <87lkyupz5j.fsf@jurta.org> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1134149997 30386 80.91.229.2 (9 Dec 2005 17:39:57 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 9 Dec 2005 17:39:57 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Dec 09 18:39:54 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1Ekm7t-0006a0-1k for ged-emacs-devel@m.gmane.org; Fri, 09 Dec 2005 18:33:46 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ekm7I-0001VS-4l for ged-emacs-devel@m.gmane.org; Fri, 09 Dec 2005 12:33:08 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1EkjOx-0003hm-Mq for emacs-devel@gnu.org; Fri, 09 Dec 2005 09:39:14 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1EkjOv-0003g5-0x for emacs-devel@gnu.org; Fri, 09 Dec 2005 09:39:10 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EkjOu-0003fq-I9 for emacs-devel@gnu.org; Fri, 09 Dec 2005 09:39:08 -0500 Original-Received: from [132.204.24.67] (helo=mercure.iro.umontreal.ca) by monty-python.gnu.org with esmtp (Exim 4.34) id 1EkjQ6-0003ju-WF for emacs-devel@gnu.org; Fri, 09 Dec 2005 09:40:23 -0500 Original-Received: from hidalgo.iro.umontreal.ca (hidalgo.iro.umontreal.ca [132.204.27.50]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id A76232CF6CB; Fri, 9 Dec 2005 09:38:44 -0500 (EST) Original-Received: from asado.iro.umontreal.ca (asado.iro.umontreal.ca [132.204.24.84]) by hidalgo.iro.umontreal.ca (Postfix) with ESMTP id A52C14AC00A; Fri, 9 Dec 2005 09:38:40 -0500 (EST) Original-Received: by asado.iro.umontreal.ca (Postfix, from userid 20848) id 893EDE6C1A; Fri, 9 Dec 2005 09:38:40 -0500 (EST) Original-To: Juri Linkov In-Reply-To: <87lkyupz5j.fsf@jurta.org> (Juri Linkov's message of "Fri, 09 Dec 2005 11:55:07 +0200") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-4.853, requis 5, autolearn=not spam, AWL 0.05, BAYES_00 -4.90) X-MailScanner-From: monnier@iro.umontreal.ca X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:47312 Archived-At: >>> After saving them to files and visiting in diff-mode, sometimes I type >>> `C-c C-c' or `RET' on such index headers with the intention to visit the >>> first hunk. But instead, it visits the last hunk of the previous file >>> in the same multi-file diff. Wouldn't it be better to handle the index >>> header as part of the file header? >> >> I think you're right. Feel free to make this change, > I tried to add an optional Index regexp to diff-file-header-re: I think it's the wrong way to go. You should try and fix diff-goto-source more specifically. Stefan