From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: undo info for `*cvs-diff*' Date: Wed, 25 Jul 2007 00:48:50 -0400 Message-ID: References: <200707232122.l6NLM1BP015977@oogie-boogie.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1185338997 17048 80.91.229.12 (25 Jul 2007 04:49:57 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 25 Jul 2007 04:49:57 +0000 (UTC) Cc: emacs-devel@gnu.org To: Dan Nicolaescu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jul 25 06:49:55 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IDYop-0000Bo-7U for ged-emacs-devel@m.gmane.org; Wed, 25 Jul 2007 06:49:51 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IDYoo-0002tx-RB for ged-emacs-devel@m.gmane.org; Wed, 25 Jul 2007 00:49:50 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IDYnv-0002a7-Qo for emacs-devel@gnu.org; Wed, 25 Jul 2007 00:48:55 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IDYns-0002Ya-Tj for emacs-devel@gnu.org; Wed, 25 Jul 2007 00:48:55 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IDYns-0002YV-Ha for emacs-devel@gnu.org; Wed, 25 Jul 2007 00:48:52 -0400 Original-Received: from tomts13.bellnexxia.net ([209.226.175.34] helo=tomts13-srv.bellnexxia.net) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IDYns-0003ha-30 for emacs-devel@gnu.org; Wed, 25 Jul 2007 00:48:52 -0400 Original-Received: from ceviche.home ([70.53.195.145]) by tomts13-srv.bellnexxia.net (InterMail vM.5.01.06.13 201-253-122-130-113-20050324) with ESMTP id <20070725044851.XJE13659.tomts13-srv.bellnexxia.net@ceviche.home> for ; Wed, 25 Jul 2007 00:48:51 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id DC512B4010; Wed, 25 Jul 2007 00:48:50 -0400 (EDT) In-Reply-To: (Reiner Steib's message of "Tue\, 24 Jul 2007 23\:28\:37 +0200") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1.50 (gnu/linux) X-detected-kernel: Solaris 8 (1) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:75512 Archived-At: > ,----[ *Warnings* ] > | Warning (undo): Buffer `*cvs-diff*' undo info was 5641808 bytes long. > | The undo info was discarded because it exceeded `undo-outer-limit'. > | [...] > `---- I believe I know what was causing this trouble. Can you try the patch below which I just installed in the 22 branch? Stefan --- pcvs.el 25 jui 2007 00:41:22 -0400 1.98.2.4 +++ pcvs.el 25 jui 2007 00:43:49 -0400 @@ -392,17 +392,18 @@ (with-current-buffer buf (setq buffer-read-only nil) (setq default-directory dir) - (unless nosetup (erase-buffer)) + (unless nosetup + (buffer-disable-undo) + (erase-buffer)) (set (make-local-variable 'cvs-buffer) cvs-buf) ;;(cvs-minor-mode 1) (let ((lbd list-buffers-directory)) - (if (fboundp mode) (funcall mode) - (fundamental-mode) - (buffer-disable-undo)) + (if (fboundp mode) (funcall mode) (fundamental-mode)) (when lbd (set (make-local-variable 'list-buffers-directory) lbd))) (cvs-minor-mode 1) ;;(set (make-local-variable 'cvs-buffer) cvs-buf) - (unless normal + (if normal + (buffer-enable-undo) (setq buffer-read-only t) (buffer-disable-undo)) buf)))