unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: raman@users.sf.net
Cc: emacs-pretest-bug@gnu.org
Subject: Re: 23.0.50; interactive-form on advised commands returns compiled advice
Date: Mon, 10 Sep 2007 10:27:23 -0400	[thread overview]
Message-ID: <jwvy7fe7g2h.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <18149.17301.189511.214535@gargle.gargle.HOWL> (T. V. Raman's message of "Mon\, 10 Sep 2007 06\:16\:05 -0700")

> Here is a more accurate description of the problem.

> If you define an advice on a  command, and in that advice you
> provide an interactive form,
> then calling interactive-form later on that function ends up
> returning what was created through the advice, and that turns out
> to be a piece of code.

> I'm hitting this because of how I end up having to advice
> commands like copy-to-register -- 
> whose interactive forms wouldn't provide speech feedback
> otherwise.

Please give me more concrete data.  Here's what I tried:

   ELISP> (defadvice diff-refine-ignore-spaces-hunk (around sm-test activate)
            (interactive "")
            ad-do-it)
   diff-refine-ignore-spaces-hunk
   ELISP> (interactive-form 'diff-refine-ignore-spaces-hunk)
   (interactive "")
   
   ELISP> 

looks correct so far.


        Stefan

  reply	other threads:[~2007-09-10 14:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-09 23:48 23.0.50; interactive-form on advised commands returns compiled advice raman
2007-09-10  2:55 ` Stefan Monnier
2007-09-10 13:16   ` T. V. Raman
2007-09-10 14:27     ` Stefan Monnier [this message]
2007-09-11  2:02       ` T. V. Raman
2007-09-11  3:04         ` Stefan Monnier
2007-09-10 23:55     ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvy7fe7g2h.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-pretest-bug@gnu.org \
    --cc=raman@users.sf.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).