23.0.50; [PATCH]: avoid error from killed buffer during vc-annotate

23.0.50; [PATCH]: avoid error from killed buffer during vc-annotate

[Eric Hanchrow]

Please write in English if possible, because the Emacs maintainers
usually do not have translators to read other languages for them.

Your bug report will be posted to the emacs-pretest-bug@gnu.org mailing list.

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:

I typed C-x v g in a version-controlled buffer (controlled by git, if
it matters) and saw an error that said "Selecting Deleted Buffer".  So
this patch prevents that from happening.

--- vc.el.~1.505.~	2008-01-05 11:05:27.484375000 -0800
+++ vc.el	2008-01-05 23:37:17.062500000 -0800
@@ -1308,6 +1308,7 @@
   (if vc-dired-mode
       (set-buffer (find-file-noselect (dired-get-filename)))
     (while (and vc-parent-buffer
+		(buffer-name vc-parent-buffer)
 		;; Avoid infinite looping when vc-parent-buffer and
 		;; current buffer are the same buffer.
  		(not (eq vc-parent-buffer (current-buffer))))


Diffs between working revision and workfile end here.

If Emacs crashed, and you have the Emacs process in the gdb debugger,
please include the output from the following gdb commands:
    `bt full' and `xbacktrace'.
If you would like to further debug the crash, please read the file
c:/cygwin/usr/local/src/emacs-cvs/etc/DEBUG for instructions.


In GNU Emacs 23.0.50.1 (i386-mingw-nt5.1.2600)
 of 2008-01-05 on FLAP
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4)'

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: nil
  locale-coding-system: cp1252
  default-enable-multibyte-characters: t

Major mode: Diff

Minor modes in effect:
  vc-parent-buffer: vc.el
  erc-autojoin-mode: t
  erc-match-mode: t
  erc-log-mode: t
  erc-services-mode: t
  desktop-save-mode: t
  recentf-mode: t
  shell-dirtrack-mode: t
  display-time-mode: t
  iswitchb-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  unify-8859-on-encoding-mode: t
  utf-translate-cjk-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
C-M-q M-~ C-x k <return> q C-x k <return> g ~ x y e 
s <return> C-u C-p C-u C-p C-u C-p C-u C-p C-n <return> 
C-x k <return> C-n <return> C-x v g C-n C-x v g M-x 
r o <backspace> <backspace> t o g g l e - d e <tab> 
e <tab> <return> C-x v g <tab> <return> C-x o q C-x 
b <return> C-u C-M-x C-x b <return> M-x M-p <return> 
C-x v g SPC SPC SPC SPC SPC SPC SPC SPC SPC SPC SPC 
SPC SPC SPC SPC C-a q C-h i d m e l i <tab> <return> 
i k i l l e d <return> , , t C-s k i l l e d SPC b 
u f f e r C-s C-a C-u C-p C-u C-p C-u C-p q C-x b . 
e l <return> C-p C-p C-p M-m C-M-o C-h f C-g M-( v 
u <backspace> <backspace> b u f f e r - n a m e SPC 
v c M-/ C-h f <return> C-x C-s C-M-x C-x o C-x b <return> 
C-x v g C-x 0 C-x v . C-x v . C-x b . e l <return> 
C-x v = C-x 0 M-< C-M-s ( a n d SPC C-g C-h s C-x o 
C-x 0 C-M-s ( a n d SPC \ s _ <backspace> <backspace> 
_ <backspace> s - <backspace> _ + C-g C-a C-M-s \ s 
_ C-s C-s C-a C-x b h e <return> C-s i d e n C-a C-x 
b <return> C-M-s ( a n d SPC . * ? - b u f f e r C-s 
C-s C-s <return> M-- C-l C-x b d i f <return> M-x r 
e p o r t - e m <tab> <return>

Recent messages:
Wrote c:/cygwin/usr/local/src/emacs-cvs/lisp/vc.el
vc-ensure-vc-buffer
Annotating...
Redisplaying annotation...done (Spanned from 565.9 to 264.4 days old)
Annotating... done
Finding changes in c:/cygwin/usr/local/src/emacs-cvs/lisp/vc.el...
Mark set
Quit
Type C-x 1 to delete the help window, C-M-v to scroll help.
Mark saved where search started [4 times]

Re: 23.0.50; [PATCH]: avoid error from killed buffer during vc-annotate

[Stefan Monnier]

> +		(buffer-name vc-parent-buffer)

Thanks for the report.  That looks good.


        Stefan


PS: When used as a boolean value, I prefer to use buffer-live-p.