From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel,gmane.emacs.pretest.bugs Subject: Re: 23.0.60; Cannot isearch for non-ascii chars with emacs -nw -Q Date: Wed, 27 Feb 2008 23:05:54 -0500 Message-ID: References: <87oda4d6h8.fsf@fastmail.fm> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1204171577 23441 80.91.229.12 (28 Feb 2008 04:06:17 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 28 Feb 2008 04:06:17 +0000 (UTC) Cc: emacs-pretest-bug@gnu.org, thorn+news@fastmail.fm To: Kenichi Handa Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Feb 28 05:06:42 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JUa2b-00047d-8P for ged-emacs-devel@m.gmane.org; Thu, 28 Feb 2008 05:06:41 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JUa24-0008NF-W9 for ged-emacs-devel@m.gmane.org; Wed, 27 Feb 2008 23:06:09 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JUa21-0008Mw-7w for emacs-devel@gnu.org; Wed, 27 Feb 2008 23:06:05 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JUa20-0008Mj-7W for emacs-devel@gnu.org; Wed, 27 Feb 2008 23:06:04 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JUa20-0008Me-3c for emacs-devel@gnu.org; Wed, 27 Feb 2008 23:06:04 -0500 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JUa1z-0007lg-PG for emacs-devel@gnu.org; Wed, 27 Feb 2008 23:06:03 -0500 Original-Received: from mx10.gnu.org ([199.232.76.166]) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1JUa1z-0008GW-Hd for emacs-pretest-bug@gnu.org; Wed, 27 Feb 2008 23:06:03 -0500 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1JUa1w-0007kT-HO for emacs-pretest-bug@gnu.org; Wed, 27 Feb 2008 23:06:03 -0500 Original-Received: from ironport2-out.pppoe.ca ([206.248.154.182]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JUa1w-0007kA-6V for emacs-pretest-bug@gnu.org; Wed, 27 Feb 2008 23:06:00 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ao8CAJHBxUdMCpz5Wmdsb2JhbACQXgEgnW2BAg X-IronPort-AV: E=Sophos;i="4.25,417,1199682000"; d="scan'208";a="15331185" Original-Received: from smtp.pppoe.ca ([65.39.196.238]) by ironport2-out.pppoe.ca with ESMTP; 27 Feb 2008 23:05:59 -0500 Original-Received: from pastel.home ([76.10.156.249]) by smtp.pppoe.ca (Internet Mail Server v1.0) with ESMTP id IGH87958; Wed, 27 Feb 2008 23:05:58 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 019A57F25; Wed, 27 Feb 2008 23:05:54 -0500 (EST) In-Reply-To: (Kenichi Handa's message of "Thu, 28 Feb 2008 11:02:56 +0900") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:90691 gmane.emacs.pretest.bugs:21329 Archived-At: >> > It seems that something is broken in isearch-x.el (although >> > unicode merge didn't change it). I'm now investigating. > I found that when isearch-printing-char is called, > last-command-char is already what decoded by > encoded-kbd-mode. That's good, right? > But, when I wrote isearch-x.el, last-command-char was the first byte > of utf-8 sequence. So, isearch-x.el pushed back that byte in > unread-command-events and re-read the whole utf-8 sequence. I see your patch doesn't remove this use of unread-command-events. Is it still needed? >> Now that we've moved the keyboard decoding to input-event-map, > Ah! Is that the change I wrote above? I don't see why that change would have such an effect. Actually, it seems that this "new" behavior is already present in the 22 branch, maybe even in Emacs-22.1. So it looks like the (if (and enable-multibyte-characters (>= char ?\200) (<= char ?\377)) test has been harmful for a while, but in the non-unicode branch, the o200-o377 range was never matched by "untranslated" data, whereas in the unicode branch these are now perfectly valid latin-1 chars. >> I'm not sure what would be the benefit. Of course, if we >> can just reuse C code and get rid of the encoded-kbd code, >> that's good. > Yes. I think it can be done by adding less than 100 lines > of C code (mostly for handling meta-key) in > tty_read_avail_input and removing most of encoded-kb.el (we > still need the code of calling set-input-mode property). Might worth trying, Stefan