From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Pretest next week Date: Wed, 28 Jan 2009 21:11:46 -0500 Message-ID: References: <87y6x4ue2u.fsf@cyd.mit.edu> <87mydjv4bd.fsf@cyd.mit.edu> <08054F25-1F90-4795-9FFE-01363F6900CE@gmail.com> <497E6D32.9000707@gnu.org> <87tz7kawln.fsf@cyd.mit.edu> <4980268C.9020104@gnu.org> <3765D6BE-634B-4D1E-AF8B-7822957F88C7@gmail.com> <6634D95E-39A0-410C-8F28-065D997D5208@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1233195125 24943 80.91.229.12 (29 Jan 2009 02:12:05 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 29 Jan 2009 02:12:05 +0000 (UTC) Cc: Chong Yidong , emacs-devel@gnu.org, Jason Rumney To: Adrian Robert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jan 29 03:13:18 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LSMP5-0007B9-NI for ged-emacs-devel@m.gmane.org; Thu, 29 Jan 2009 03:13:16 +0100 Original-Received: from localhost ([127.0.0.1]:49995 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LSMNn-0007RQ-A1 for ged-emacs-devel@m.gmane.org; Wed, 28 Jan 2009 21:11:55 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LSMNj-0007RF-B0 for emacs-devel@gnu.org; Wed, 28 Jan 2009 21:11:51 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LSMNi-0007Qf-4w for emacs-devel@gnu.org; Wed, 28 Jan 2009 21:11:50 -0500 Original-Received: from [199.232.76.173] (port=34991 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LSMNh-0007QX-Vs for emacs-devel@gnu.org; Wed, 28 Jan 2009 21:11:50 -0500 Original-Received: from ironport2-out.pppoe.ca ([206.248.154.182]:12949 helo=ironport2-out.teksavvy.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LSMNg-0001oH-A6; Wed, 28 Jan 2009 21:11:48 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AhIFAHufgEnO+LLC/2dsb2JhbACBbslGhUcGgjw X-IronPort-AV: E=Sophos;i="4.37,340,1231131600"; d="scan'208";a="32958282" Original-Received: from 206-248-178-194.dsl.teksavvy.com (HELO pastel.home) ([206.248.178.194]) by ironport2-out.teksavvy.com with ESMTP; 28 Jan 2009 21:11:46 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id B71488120; Wed, 28 Jan 2009 21:11:46 -0500 (EST) In-Reply-To: (Adrian Robert's message of "Wed, 28 Jan 2009 21:25:38 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:108346 Archived-At: > Yes, adding > else if (pending_atimers) \ > do_pending_atimers(); \ > at the end of QUIT allows poll_timer() to fire under SYNC_INPUT and Ctrl-g > to be detected, with no apparent other ill effects (in very limited > testing). Good. >> If so, we should probably create a new >> var `pending_signals', which should always reflect >> "pending_timers || interrupt_input_pending" > I'm not sure if the extra 0-comparison would significantly add to overhead > but I guess code size could take a hit. It's easy for the CPU to predict those jumps, but I still think the current QUIT is already pretty costly, so I'd rather not make it worse. > Though maybe the part of QUIT above (when there is a quit_flag) could > also be reduced to a function call to slim things down? Yes, that would be good as well. Stefan