From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: RFC: [PATCH] isearch enhancements: symbol mode; syntactic filtering Date: Thu, 07 Jul 2011 16:51:26 -0400 Message-ID: References: <4E15C0BA.10400@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1310072135 30316 80.91.229.12 (7 Jul 2011 20:55:35 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 7 Jul 2011 20:55:35 +0000 (UTC) Cc: emacs-devel@gnu.org To: Daniel Colascione Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jul 07 22:55:31 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Qevbe-0000v3-O9 for ged-emacs-devel@m.gmane.org; Thu, 07 Jul 2011 22:55:30 +0200 Original-Received: from localhost ([::1]:51375 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qevbd-0007m5-L9 for ged-emacs-devel@m.gmane.org; Thu, 07 Jul 2011 16:55:29 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:52298) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QevXy-0006uz-AF for emacs-devel@gnu.org; Thu, 07 Jul 2011 16:51:48 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QevXs-0007MQ-O0 for emacs-devel@gnu.org; Thu, 07 Jul 2011 16:51:42 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:60608) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QevXq-00073l-S2 for emacs-devel@gnu.org; Thu, 07 Jul 2011 16:51:36 -0400 Original-Received: from faina.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id p67KpQtd008139; Thu, 7 Jul 2011 16:51:26 -0400 Original-Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id 7B5DCB4177; Thu, 7 Jul 2011 16:51:26 -0400 (EDT) In-Reply-To: <4E15C0BA.10400@gmail.com> (Daniel Colascione's message of "Thu, 07 Jul 2011 07:20:42 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3911=0 X-NAI-Spam-Version: 2.2.0.9286 : core <3911> : streams <658562> : uri <909073> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:141748 Archived-At: We're in feature freeze, so it's not a good time to integrate such changes. I haven't had time to look at them, but have one comment below: > Bugfixes > -------- > - After an isearch settings change, we refresh the state stored at the to of > the stack. This way, we don't lose track of settings after adding characters > to the search string and removing them again. IIUC that's not a bug, it's a feature. When I switch to regexp search after starting a normal search, I don't want to revert to non-regexp search just because I noticed that there was a typo and used backspace a few times to go fixing that typo. Stefan