unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: [Emacs-diffs] /srv/bzr/emacs/trunk r111831: * sheap.c (report_sheap_usage): Use message, not message1, so
       [not found] <E1U82zY-0001GG-O8@vcs.savannah.gnu.org>
@ 2013-02-20 14:21 ` Stefan Monnier
  2013-02-20 20:44   ` Ken Brown
  0 siblings, 1 reply; 6+ messages in thread
From: Stefan Monnier @ 2013-02-20 14:21 UTC (permalink / raw)
  To: dancol; +Cc: emacs-devel

> -  message1 (buf);
> +  /* Don't change this call to message1! message1 can log
> +     messages, and at this point, we're not allowed to create
> +     buffers.  */
> +  message ("%s", buf);

Thanks for finding it.  Can you check if

   message1_nolog (buf);

works as well?


        Stefan



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Emacs-diffs] /srv/bzr/emacs/trunk r111831: * sheap.c (report_sheap_usage): Use message, not message1, so
  2013-02-20 14:21 ` [Emacs-diffs] /srv/bzr/emacs/trunk r111831: * sheap.c (report_sheap_usage): Use message, not message1, so Stefan Monnier
@ 2013-02-20 20:44   ` Ken Brown
  2013-02-20 21:02     ` Stefan Monnier
  0 siblings, 1 reply; 6+ messages in thread
From: Ken Brown @ 2013-02-20 20:44 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: dancol, emacs-devel

On 2/20/2013 9:21 AM, Stefan Monnier wrote:
>> -  message1 (buf);
>> +  /* Don't change this call to message1! message1 can log
>> +     messages, and at this point, we're not allowed to create
>> +     buffers.  */
>> +  message ("%s", buf);
>
> Thanks for finding it.  Can you check if
>
>     message1_nolog (buf);
>
> works as well?

Works for me.

Ken




^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Emacs-diffs] /srv/bzr/emacs/trunk r111831: * sheap.c (report_sheap_usage): Use message, not message1, so
  2013-02-20 20:44   ` Ken Brown
@ 2013-02-20 21:02     ` Stefan Monnier
  2013-02-20 21:16       ` Ken Brown
  0 siblings, 1 reply; 6+ messages in thread
From: Stefan Monnier @ 2013-02-20 21:02 UTC (permalink / raw)
  To: Ken Brown; +Cc: dancol, emacs-devel

>>> -  message1 (buf);
>>> +  /* Don't change this call to message1! message1 can log
>>> +     messages, and at this point, we're not allowed to create
>>> +     buffers.  */
>>> +  message ("%s", buf);
>> Thanks for finding it.  Can you check if
>> message1_nolog (buf);
>> works as well?
> Works for me.

Thanks, installed,


        Stefan



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Emacs-diffs] /srv/bzr/emacs/trunk r111831: * sheap.c (report_sheap_usage): Use message, not message1, so
  2013-02-20 21:02     ` Stefan Monnier
@ 2013-02-20 21:16       ` Ken Brown
  2013-02-21  2:36         ` Ken Brown
  0 siblings, 1 reply; 6+ messages in thread
From: Ken Brown @ 2013-02-20 21:16 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: dancol, emacs-devel

On 2/20/2013 4:02 PM, Stefan Monnier wrote:
>>>> -  message1 (buf);
>>>> +  /* Don't change this call to message1! message1 can log
>>>> +     messages, and at this point, we're not allowed to create
>>>> +     buffers.  */
>>>> +  message ("%s", buf);
>>> Thanks for finding it.  Can you check if
>>> message1_nolog (buf);
>>> works as well?
>> Works for me.
>
> Thanks, installed,


> +  message1_nolog ("%s", buf);

This should be

      message1_nolog (buf);

Ken



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Emacs-diffs] /srv/bzr/emacs/trunk r111831: * sheap.c (report_sheap_usage): Use message, not message1, so
  2013-02-20 21:16       ` Ken Brown
@ 2013-02-21  2:36         ` Ken Brown
  2013-02-21 15:24           ` Stefan Monnier
  0 siblings, 1 reply; 6+ messages in thread
From: Ken Brown @ 2013-02-21  2:36 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: dancol, emacs-devel

On 2/20/2013 4:16 PM, Ken Brown wrote:
> On 2/20/2013 4:02 PM, Stefan Monnier wrote:
>>>>> -  message1 (buf);
>>>>> +  /* Don't change this call to message1! message1 can log
>>>>> +     messages, and at this point, we're not allowed to create
>>>>> +     buffers.  */
>>>>> +  message ("%s", buf);
>>>> Thanks for finding it.  Can you check if
>>>> message1_nolog (buf);
>>>> works as well?
>>> Works for me.
>>
>> Thanks, installed,
>
>
>> +  message1_nolog ("%s", buf);
>
> This should be
>
>       message1_nolog (buf);

I've just fixed this in bzr revision 111839.

Ken



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Emacs-diffs] /srv/bzr/emacs/trunk r111831: * sheap.c (report_sheap_usage): Use message, not message1, so
  2013-02-21  2:36         ` Ken Brown
@ 2013-02-21 15:24           ` Stefan Monnier
  0 siblings, 0 replies; 6+ messages in thread
From: Stefan Monnier @ 2013-02-21 15:24 UTC (permalink / raw)
  To: Ken Brown; +Cc: dancol, emacs-devel

>>> +  message1_nolog ("%s", buf);
>> This should be
>> message1_nolog (buf);

Duh!

> I've just fixed this in bzr revision 111839.

Thank you, and sorry,


        Stefan



^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2013-02-21 15:24 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <E1U82zY-0001GG-O8@vcs.savannah.gnu.org>
2013-02-20 14:21 ` [Emacs-diffs] /srv/bzr/emacs/trunk r111831: * sheap.c (report_sheap_usage): Use message, not message1, so Stefan Monnier
2013-02-20 20:44   ` Ken Brown
2013-02-20 21:02     ` Stefan Monnier
2013-02-20 21:16       ` Ken Brown
2013-02-21  2:36         ` Ken Brown
2013-02-21 15:24           ` Stefan Monnier

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).