From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: trunk r114048: * src/eval.c (Ffuncall): Fix handling of ((lambda ..) ..) in lexically Date: Fri, 06 Sep 2013 11:11:55 -0400 Message-ID: References: <87bo46yai6.fsf@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; CHARSET=US-ASCII Content-Transfer-Encoding: 7BIT X-Trace: ger.gmane.org 1378480329 13969 80.91.229.3 (6 Sep 2013 15:12:09 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 6 Sep 2013 15:12:09 +0000 (UTC) Cc: emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Sep 06 17:12:11 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VHxhj-0003N7-Ew for ged-emacs-devel@m.gmane.org; Fri, 06 Sep 2013 17:12:11 +0200 Original-Received: from localhost ([::1]:38265 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VHxhj-0007OZ-0B for ged-emacs-devel@m.gmane.org; Fri, 06 Sep 2013 11:12:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34089) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VHxhZ-0007OB-DF for emacs-devel@gnu.org; Fri, 06 Sep 2013 11:12:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VHxhS-0004JF-3G for emacs-devel@gnu.org; Fri, 06 Sep 2013 11:12:01 -0400 Original-Received: from relais.videotron.ca ([24.201.245.36]:11857) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VHxhR-0004J8-V4 for emacs-devel@gnu.org; Fri, 06 Sep 2013 11:11:54 -0400 Original-Received: from ceviche.home ([24.203.189.74]) by VL-VM-MR005.ip.videotron.ca (Oracle Communications Messaging Exchange Server 7u4-22.01 64bit (built Apr 21 2011)) with ESMTP id <0MSP00B7EM7TO300@VL-VM-MR005.ip.videotron.ca> for emacs-devel@gnu.org; Fri, 06 Sep 2013 11:11:53 -0400 (EDT) Original-Received: by ceviche.home (Postfix, from userid 20848) id BCDB066086; Fri, 06 Sep 2013 11:11:55 -0400 (EDT) In-reply-to: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 24.201.245.36 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:163229 Archived-At: >> This change lowers the performance of the js2-mode parser (which still >> uses dynamic scoping, by the way) by the factor of five. > That's very odd. I must be doing something wrong there. Indeed, I was calling Ffunction for every function that's not an alias instead of for every function that's not given as a symbol. I installed a change which should hopefully fix this. Please confirm that it does. >> Incidentally, the slowdown factor is similar to I've seen when trying to >> measure its performance in lexical-binding mode before this revision. >> pre-114048, lexical-binding: t -- 3.95 seconds >> 114048+, lexical-binding: t -- 7-8 seconds >> Should I file a dedicated bug? Lexical-binding is a bit faster in some cases and a bit slower in others, so a change is not unheard of, but this large of a change is unusual (tho I can imagine ways in which that could happen). I'd be interested in running your test to try and see where the perforce loss comes from. BTW, is this with js2-mode compiled or interpreted? Stefan