From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Emacs pretest -- electric-pair-mode change Date: Fri, 04 Apr 2014 08:53:23 -0400 Message-ID: References: <87d2h0ujls.fsf_-_@kitaj.lan> <87sipujhq2.fsf@kitaj.lan> <87mwg1jz43.fsf@kitaj.lan> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1396616045 6395 80.91.229.3 (4 Apr 2014 12:54:05 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 4 Apr 2014 12:54:05 +0000 (UTC) Cc: emacs-devel@gnu.org To: joaotavora@gmail.com (=?windows-1252?B?Sm/jbyBU4XZvcmE=?=) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Apr 04 14:53:58 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WW3cz-0007wf-SL for ged-emacs-devel@m.gmane.org; Fri, 04 Apr 2014 14:53:49 +0200 Original-Received: from localhost ([::1]:49714 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WW3cz-0004TH-90 for ged-emacs-devel@m.gmane.org; Fri, 04 Apr 2014 08:53:49 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35472) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WW3co-0004TA-Rx for emacs-devel@gnu.org; Fri, 04 Apr 2014 08:53:46 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WW3ch-0000h7-98 for emacs-devel@gnu.org; Fri, 04 Apr 2014 08:53:38 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:54257) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WW3ch-0000h3-1l for emacs-devel@gnu.org; Fri, 04 Apr 2014 08:53:31 -0400 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id s34CrO03003720; Fri, 4 Apr 2014 08:53:25 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id A49BD6011E; Fri, 4 Apr 2014 08:53:24 -0400 (EDT) In-Reply-To: <87mwg1jz43.fsf@kitaj.lan> (=?windows-1252?Q?=22Jo=E3o_T=E1vo?= =?windows-1252?Q?ra=22's?= message of "Fri, 04 Apr 2014 09:08:28 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4902=0 X-NAI-Spam-Version: 2.3.0.9378 : core <4902> : inlines <689> : streams <1151992> : uri <1720181> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:171310 Archived-At: > OK so something like this is acceptable for trunk & 24.4? Looks OK, yes. > (defun electric-pair--unbalanced-strings-p (char) > "Return non-nil if there are unbalanced strings started by CHAR" Please terminate with ".". > (let* ((selector-ppss (syntax-ppss)) > (relevant-ppss (save-excursion > (if (nth 4 selector-ppss) ; in comment > (let ((comment-start > (progn > (goto-char (line-beginning-position)) Huh? Shouldn't this use (nth 8 (syntax-ppss))? Stefan