From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: Michael Albinus <michael.albinus@gmx.de>, emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master adfb6f1: Continue to fix bug#25607
Date: Wed, 15 Feb 2017 16:50:58 -0500 [thread overview]
Message-ID: <jwvy3x7nnt9.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <8e6b7990-3424-6780-ddc7-8ae36cff06d0@yandex.ru> (Dmitry Gutov's message of "Wed, 15 Feb 2017 22:41:01 +0200")
>>> * lisp/ido.el (ido-complete): Let-bind `non-essential' to nil.
>> This looks wrong. This in an interactive command executing an explicit
>> request from the user, so it's definitely not non-essential.
> Hence "to nil"?
Oh, right, sorry, duh! Indeed, it's perfectly safe then to bind it to
nil there.
Hmm... then I wonder why this binding would be needed at all: why wouldn't
the variable already be nil?
[...time passes...]
Oh, I see: there is an incorrect binding in ido-read-internal which
means that all commands within IDO are treated as non-essential.
The way I see it, The Right Way would be to do the binding in
ido-exhibit, since that's the code run from post-command-hook, i.e. the
code that's not explicitly requested by the user.
Stefan
diff --git a/lisp/ido.el b/lisp/ido.el
index e18464d1d6b..bb4c67c7c01 100644
--- a/lisp/ido.el
+++ b/lisp/ido.el
@@ -1882,7 +1882,6 @@ ido-read-internal
ido-selected
ido-final-text
(done nil)
- (non-essential t) ;; prevent eager Tramp connection
(icomplete-mode nil) ;; prevent icomplete starting up
;; Exported dynamic variables:
ido-cur-list
@@ -3556,7 +3555,6 @@ ido-file-name-all-completions-1
;; Strip method:user@host: part of tramp completions.
;; Tramp completions do not include leading slash.
(let* ((len (1- (length dir)))
- (non-essential t)
(compl
(or ;; We do not want to be disturbed by "File does not
;; exist" errors.
@@ -4413,6 +4411,7 @@ ido-exhibit
(when (ido-active)
(let ((contents (buffer-substring-no-properties (minibuffer-prompt-end) (point-max)))
+ (non-essential t)
(buffer-undo-list t)
try-single-dir-match
refresh)
next prev parent reply other threads:[~2017-02-15 21:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170215184246.30452.62655@vcs0.savannah.gnu.org>
[not found] ` <20170215184247.DC51023357@vcs0.savannah.gnu.org>
2017-02-15 20:35 ` [Emacs-diffs] master adfb6f1: Continue to fix bug#25607 Stefan Monnier
2017-02-15 20:41 ` Dmitry Gutov
2017-02-15 21:45 ` Michael Albinus
2017-02-15 21:50 ` Stefan Monnier [this message]
2017-02-16 13:36 ` Michael Albinus
2017-02-16 15:01 ` Stefan Monnier
2017-02-15 21:41 ` Michael Albinus
2017-03-15 10:41 ` Michael Albinus
2017-03-15 14:41 ` Stefan Monnier
2017-03-15 14:48 ` Michael Albinus
2017-03-15 15:03 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvy3x7nnt9.fsf-monnier+emacsdiffs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).