From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Native display of line numbers Date: Sat, 17 Jun 2017 12:41:50 -0400 Message-ID: References: <83lgoqzm0v.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1497721874 9174 195.159.176.226 (17 Jun 2017 17:51:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 17 Jun 2017 17:51:14 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jun 17 19:51:10 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dMHsK-00027B-Sx for ged-emacs-devel@m.gmane.org; Sat, 17 Jun 2017 19:51:08 +0200 Original-Received: from localhost ([::1]:35857 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dMHsQ-0003Uq-2x for ged-emacs-devel@m.gmane.org; Sat, 17 Jun 2017 13:51:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35767) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dMHrm-0003TX-Aa for emacs-devel@gnu.org; Sat, 17 Jun 2017 13:50:35 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dMHrh-0004dI-EI for emacs-devel@gnu.org; Sat, 17 Jun 2017 13:50:34 -0400 Original-Received: from [195.159.176.226] (port=35687 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dMHrh-0004cv-77 for emacs-devel@gnu.org; Sat, 17 Jun 2017 13:50:29 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1dMGnH-0004wU-DV for emacs-devel@gnu.org; Sat, 17 Jun 2017 18:41:51 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 28 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:HeLEa88Oa6Ot19pPNuCZDqoPLcg= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:215708 Archived-At: > So with that in mind, I came up with an implementation of a native > display of line numbers. Cool! > . it works significantly faster (almost twice as fast as linum-mode, > 50% faster that relative-line-numbers-mode) Should I read this to me that the speed difference w.r.t nlinum is not that large, or you didn't bother comparing? (I think nlinum's performance is pretty good (well, as long as the number of overlays doesn't get in the way, as long as you don't try to push it towards relative-line-number, as long as you don't enable the new nlinum-highlight-current-line which currently has a performance bug, ...)). > . it works with R2L text, something the old modes never did I didn't know there were problems with R2L text. Worse: even now that you tell me, I can't think of nor find a problem with it (other than the choice of whether to display the line numbers in the left or right margin). I'm curious what these issues are (or were, since your code will presumably make these limitations irrelevant). Stefan